Repository navigation
Conversation
TGB-configured repositories now read only the TGB blob from the cache. The gob fallback path is removed: a corrupt or missing TGB blob propagates the error directly so the orchestrator recomputes and overwrites, rather than serving a stale gob blob from an earlier format era. This mirrors the matching internal monorepo change. Production has been fully on TGB long enough that the gob fallback was dead code obscuring real cache state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The controller test suite exceeds Bazel's default 300s timeout on GitHub Actions runners. Bump size to "large" (900s) so CI completes reliably.
Coverage instrumentation makes the controller test suite significantly slower. The "large" (900s) timeout is not enough under bazel coverage on CI runners. Bump to "enormous" (3600s).
yushan8
reviewed
Oct 7, 2026
|
|
||
| go_test( | ||
| name = "controller_test", | ||
| size = "enormous", |
Contributor
Author
There was a problem hiding this comment.
thanks. I thought our test is slow, turned out I broke it
yushan8
approved these changes
Oct 7, 2026
…eout The TGBMixedFormatFallsBack test validated the gob fallback path that was retired in this branch. With the fallback removed, the mock orchestrator received an unexpected call inside a goroutine, killing it via t.Fatalf without sending on the results channel — hanging fetchTargetGraphs forever. Revert the enormous test size bump that was a workaround for the hang.
xytan0056
force-pushed
the
xytan0056/retire-gob-fallback
branch
from
October 9, 2026 15:14
e4eb4fa to
fc514d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TGB coding is proven to be effective within Uber. It should be an exclusive option to GOB
readCachedGraphfor TGB-configured repositories. A corrupt or missing TGB blob now propagates the error directly instead of falling back to a gob blob from an earlier format era.Test plan
Unit tested
CI