Repository navigation
docs(rfc): Fold the queue pause decision into the RFC - #871
Merged
Merged
Conversation
manjari25
added this pull request to stack #868
October 14, 2026 21:00
manjari25
marked this pull request as ready for review
October 14, 2026 22:04
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 14, 2026 22:04
manjari25
force-pushed
the
manjari/queue-pause-6-docs
branch
from
October 15, 2026 00:04
36bd42f to
e547343
Compare
behinddwalls
approved these changes
Oct 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Oct 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Oct 15, 2026
manjari25
force-pushed
the
manjari/queue-pause-6-docs
branch
from
October 15, 2026 22:15
e547343 to
461e255
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 15, 2026
manjari25
force-pushed
the
manjari/queue-pause-6-docs
branch
from
October 15, 2026 22:57
461e255 to
503c039
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The pause RFC still presented two options as an open comparison, but the stack in #862 to #865 and the e2e tests implement one of them. An RFC describes what is on main, so it now records the design that shipped and only the alternative it rejected.
What?
queuepauseextension, reject (FailedPrecondition, carrying the operator's reason) and freeze, both failing closed on a read error. A cancelled context is passed through.noop,fileandfakestores,QUEUE_PAUSE_CONFIG_PATH, and the shared wiring helper.queuepause.Storemust meet, such as failing closed on read errors, strict parsing, and failing at construction on bad configuration.Test Plan
Docs only, no runnable change.
make lintpasses.Issue