Repository navigation
Conversation
manjari25
marked this pull request as draft
October 13, 2026 19:47
manjari25
force-pushed
the
manjari/tango-signature-entities-and-contracts
branch
from
October 14, 2026 02:03
5b5e9d2 to
5afc805
Compare
manjari25
marked this pull request as ready for review
October 14, 2026 02:26
manjari25
added this pull request to stack #872
October 14, 2026 21:02
| Label string | ||
|
|
||
| // CreatedAt is the Unix milliseconds timestamp when the record was created. | ||
| CreatedAt int64 |
Collaborator
There was a problem hiding this comment.
maywant to add version as well
Contributor
Author
There was a problem hiding this comment.
Both records are write-once (Create → ErrAlreadyExists, no update path), so there's no concurrent writer for a version to guard against. Per the immutable-records convention they're created, not versioned.
| Targets []SignatureTarget | ||
|
|
||
| // CreatedAt is the Unix milliseconds timestamp when the record was created. | ||
| CreatedAt int64 |
Collaborator
There was a problem hiding this comment.
may want to add version as well
Contributor
Author
There was a problem hiding this comment.
Same comment as above
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package storage |
Collaborator
There was a problem hiding this comment.
i don't think these belong in storage.. these stores are extension impl specific
Contributor
Author
There was a problem hiding this comment.
Updated per offline discussion
manjari25
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The Tango-backed conflict analyzer needs to persist each batch's affected-target signature, and a dictionary that maps the 64-bit target IDs back to their labels. This is the first PR in a stack that builds that storage layer. It defines the vocabulary and contracts only.
What?
Everything is added under
submitqueue/extension/conflict/tango, the extension that owns the data:TargetSignature,SignatureTargetandTargetLabelentities.SignatureReaderandSignatureStore:Get: returns(signature, found, error).Create: write-once, returns an already-exists error on a repeat.SignatureStoreembedsSignatureReader, so a consumer such as conflict relaxation can take the read-only view and cannot write.DictionaryReaderandDictionaryStore, keyed by(queue, ID), with the same read/write split:Create: write-once, returns an already-exists error if the ID is already recorded, even with a different label, so the first label stays.Get: returns(label, found, error). A label that differs from the caller's means a hash collision.tangopackage, not amock/subpackage, so the analyzer's same-package tests do not create an import cycle.Test Plan
make check-gazellemake check-mocksmake lint./tool/bazel test //submitqueue/extension/conflict/...CI
Issue