Repository navigation
feat(ui): side pane Files tab with workspace file browser - #34
Merged
Merged
Conversation
Add a singleton `files` side-pane tab (launcher + "+" menu) that renders the existing WorkspaceFileTree for the current workspace on desktop and web. Clicking a file opens it in a code-viewer tab, so previews cover everything the code viewer already supports (text/code, markdown, images, media, PDF, PPTX). WorkspaceFileTree.onClose is now optional; without it the "Back to tasks" button is not rendered, since an embedded tab has nothing to go back to. Spec: docs/specs/side-pane-file-browser.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filestab that renders the existingWorkspaceFileTreefor the current workspace (lazy expansion, search, changed-only filter, git status, context menu).code-viewertab next to the Files tab, so preview supports whatever the code viewer already does: text/code, markdown, images, audio/video, PDF, PPTX. No new preview implementation, service, protocol or persistence.WorkspaceFileTree.onCloseis now optional; when absent the "Back to tasks" button is not rendered (it only makes sense in the sidebar overlay).filesis a workspace-global tab type (likegit/developer-tools): one tab per workspace, visible from every conversation in it; reopening activates the existing tab.Spec:
docs/specs/side-pane-file-browser.mdTest plan
pnpm typecheckpassespnpm lint: 0 errors (80 pre-existing warnings)pnpm architecture:check --changed: 0 violationspackages/ui/test/sidePaneFilesTab.test.ts, 4 pass): launcher order incl. web without embedded browser, single-tab activation, visibility across conversations. Run withpnpm exec tsx --tsconfig packages/ui/tsconfig.json --test packages/ui/test/sidePaneFilesTab.test.ts.mdopens a rendered code-viewer tab, Files tab staysNote:
pnpm fmt:checkalready fails on 139 files onmain; none of the lines changed here are newly flagged.