[pull] master from ruby:master - #1283
Merged
Merged
Conversation
…s/pem_utilities.rb This commit refactors testing key/cert constants in a more consistent way. The key/cert constants were duplicated across the files, and there was a different constant naming `*_PATH` vs `*_FILE`. Create test/rubygems/pem_utilities.rb moving .pem methods/constants from test/rubygems/helper.rb to manage testing key/cert constants in one file. test/rubygems/local_ssl_server_utilities.rb, used by both RubyGems and Bundler, also uses these constants, so the new pem_utilities.rb must not depend on test-unit. In test/rubygems/pem_utilities.rb, added the following features compared to test/rubygems/helper.rb. * Add pem_file method for combined cert+key PEM files * Rename helper methods from key_path to key_file, from cert_path to cert_file, to consistently use the `*_FILE` suffix for constants. * Align test/rubygems/*.pem file names and constants with the pattern `<algorithm>_<name>`. If the `<algorithm>` is RSA 2048 bits, there is no `<algorithm>_` prefix as a default algorithm. * Rename `EXPIRED_PUBLIC_CERT` to `EXPIRED_CERT`. CERT is only public. There is no private cert file. * Update local_ssl_server_utilities.rb to use constants directly, removing unused methods. * Handle OpenSSL::PKey::PKeyError in load_key for unsupported algorithms on old OpenSSL versions Assisted-by: Claude:claude-opus-4-6[1m] ruby/rubygems@35d72d71e2
Previously we put a `nop` at the beginning of a block because any two
`PadPatchPoint` checked for minimum distance. The `PadPatchPoint` inserted
at block boundary isn't itself a patch point position, so when we had:
PadPatchPoint
// Enough space
PadPatchPoint // block boundary
// Not enough space
PadPatchPoint
We got an unnecessary nop.
Add a new `BoundaryPad` instruction that only pads for `PadPatchPoint`
preceding it.
Note that not all padding for patchpoints are gone, as we still pad for
when two patchpoints are too close to each other. We'd need to tweak
bookkeeping in invariants.rs to support two patchpoints having the same
code address.
I think there was a bug there because it checked for block id while iterating with reverse-post order. No need to check when we can do it unconditionally outside the loop. (Do we ever try to compile an empty assembler?)
Two reasons for this: 1. It's less weird for a pad to be zero width than for an imperative to pad to not actually pad. 2. PatchPoint is a noun so its related padding reads better when can only be interpreted as a noun.
Allow SendDirect to handle explicit caller keywords passed to callees with no keyword parameter table by materializing the keywords as one positional Hash. Keep VM dispatch for keyword splat, **nil, and ruby2_keywords cases because they need keyword-sensitive setup beyond constructing a plain Hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )