[pull] master from php:master - #1149
Merged
Merged
Conversation
Remove main/io from the Windows PHP_INSTALL_HEADERS list so Windows matches the Autotools behavior. main/php_io.h should be exported publicly.
The CLEAN section causes issues in CI on Windows + PHP 8.2 + ext-pgsql. This was fixed in 94dc6ae, but landed only in 8.3+.
* PHP-8.2: [skip ci] Remove CLEAN from GHSA-7qpv-r5mr-78m4.phpt in PHP 8.2
* PHP-8.3: [skip ci] Remove CLEAN from GHSA-7qpv-r5mr-78m4.phpt in PHP 8.2
* PHP-8.4: [skip ci] Remove CLEAN from GHSA-7qpv-r5mr-78m4.phpt in PHP 8.2
* PHP-8.5: [skip ci] Remove CLEAN from GHSA-7qpv-r5mr-78m4.phpt in PHP 8.2
php_zip_add_file() takes a char*/size_t pair, so without a prefix to concatenate the zend_string was allocated and released once per entry only to pass one through. Pass file_stripped directly, and hold basename until after the call because file_stripped can point into it. Closes GH-22975
Before the early-return refactor in d75f79e the tidy call sat on the single return path, so it ran whether or not the opener produced a stream. It now runs only when the opener fails, so anything the opener stored while REPORT_ERRORS was masked stays in FG(wrapper_logged_errors) until request shutdown and is replayed by the next failure for the same wrapper. Closes GH-22977
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )