Skip to content

Claudio/launch prep - #276

Merged
claudfuen merged 5 commits into
mainfrom
claudio/launch-prep
Apr 4, 2025
Merged

claudfuen merged 5 commits into
mainfrom
claudio/launch-prep

Conversation

@claudfuen

@claudfuen claudfuen commented Apr 4, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Upgraded framework and controls tables with interactive search, filtering, and column resizing.
    • Enhanced risk management and vendor pages with refreshed layouts and breadcrumb navigation.
    • Introduced card-based interfaces for better visual organization.
    • Updated localization strings for clearer search placeholders and terminology.

… search functionality

- Replaced traditional table structure with a responsive DataTable component for better UI.
- Implemented search functionality to filter requirements based on user input.
- Updated localization to include "Requirements" in the framework features.
- Enabled column resizing in the useDataTable hook for improved user experience.
…unctionality

- Integrated DataTable component for enhanced table structure and responsiveness.
- Added search functionality to filter controls based on user input.
- Updated localization to include search placeholder for controls.
- Improved column definitions and tooltip integration for better user experience.
… layout

- Introduced a new layout for vendor management, integrating charts for vendor status and category.
- Added a responsive design using Tailwind CSS for better user experience.
- Implemented server-side data fetching for vendor overview and assignees.
- Created components for vendor registration table, filters, and charts to enhance modularity.
- Removed outdated vendor registration page and layout for improved clarity.
- Introduced a new layout for risk management, including a responsive design using Tailwind CSS.
- Added RiskRegisterTable component for displaying risks with filtering and pagination capabilities.
- Implemented server-side data fetching for risks and assignees, ensuring type safety with next-safe-action.
- Created search parameters management using nuqs for better query state handling.
- Removed outdated risk registration layout and page for improved clarity and organization.
@vercel

vercel Bot commented Apr 4, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 0:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
comp-portal ⬜️ Skipped (Inspect) Apr 4, 2025 0:34am

@coderabbitai

coderabbitai Bot commented Apr 4, 2025 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces extensive updates to table components and page layouts across the framework, risk, and vendor modules. Legacy table structures have been replaced with new, interactive DataTable components featuring search, sorting, and column resizing. Function signatures and component interfaces have been expanded to include additional parameters (such as organization IDs) for enhanced breadcrumb navigation and dashboard filtering. Several obsolete files have been removed, and new asynchronous data fetching functions (e.g., getAssignees) have been added. Minor localization updates and hook enhancements are also included.


Changes

File(s) Change Summary
apps/app/src/app/[locale]/.../frameworks/[frameworkInstanceId]/components/FrameworkRequirements.tsx Replaced legacy table with a new DataTable; added search filtering, new state (searchTerm), and defined a new RequirementItem type; wrapped table in Card components.
apps/app/src/app/[locale]/.../frameworks/requirements/[requirementKey]/components/table/RequirementControlsTable.tsx Switched from useReactTable to a custom useDataTable hook; redefined columns with useMemo and ColumnDef; integrated search input and enhanced tooltip display.
apps/app/src/app/[locale]/.../layout.tsx Reordered import statements; removed the UserProvider import and added AssistantSheet at a new position.
apps/app/src/app/[locale]/.../risk/(overview)/page.tsx Renamed component to RiskRegisterPage; expanded parameters (search, page, pageSize, status, department, assigneeId); replaced components with RiskRegisterTable and introduced a new cached getAssignees function.
apps/app/src/app/[locale]/.../risk/[riskId]/layout.tsx
apps/app/src/app/[locale]/.../risk/register/*
Deleted legacy layout and registration components for risk management.
apps/app/src/app/[locale]/.../risk/[riskId]/page.tsx Updated to use PageWithBreadcrumb for navigation; modified the params interface to include orgId alongside riskId and locale.
apps/app/src/app/[locale]/.../risk/backup-overview/page.tsx
apps/app/src/app/[locale]/.../risk/layout.tsx
Added new risk management dashboard files supporting metadata generation and session/localization handling.
apps/app/src/app/[locale]/.../vendors/(overview)/page.tsx Updated function signature to use validated searchParams; replaced VendorOverview with VendorRegisterTable; introduced a cached getAssignees function and updated metadata to a new title.
apps/app/src/app/[locale]/.../vendors/[vendorId]/layout.tsx
apps/app/src/app/[locale]/.../vendors/register/*
Removed legacy layout and registration pages for vendors.
apps/app/src/app/[locale]/.../vendors/[vendorId]/page.tsx Modified to use PageWithBreadcrumb and updated the params interface to include orgId for breadcrumb navigation.
apps/app/src/app/[locale]/.../vendors/backup-overview/page.tsx
apps/app/src/app/[locale]/.../vendors/layout.tsx
Introduced new vendor dashboard and backup overview files with updated session and localization handling.
apps/app/src/hooks/use-data-table.ts Enabled column resizing in the DataTable by adding enableColumnResizing: true in the useReactTable configuration.
apps/app/src/locales/features/frameworks.ts Added new localization entries: a search placeholder under controls and a new label for requirements.
apps/app/src/locales/features/people.ts Changed the label from "All Employees" to "Employees" and standardized indentation formatting.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FrameworkComponent
    participant DataTable
    participant TableRenderer

    User->>FrameworkComponent: Enter search term
    FrameworkComponent->>DataTable: Filter requirements based on search
    DataTable->>TableRenderer: Provide filtered data for rendering
    TableRenderer-->>User: Display updated requirement list
Loading
sequenceDiagram
    participant User
    participant RiskRegisterPage
    participant getAssignees
    participant Database
    participant RiskRegisterTable

    User->>RiskRegisterPage: Request risk page
    RiskRegisterPage->>getAssignees: Fetch assignees asynchronously
    getAssignees->>Database: Query active members
    Database-->>getAssignees: Return assignee data
    getAssignees-->>RiskRegisterPage: Provide assignees
    RiskRegisterPage->>RiskRegisterTable: Render risks with assignees
    RiskRegisterTable-->>User: Display risk dashboard
Loading

Possibly related PRs


Poem

In the code garden where rows align,
I hop with joy as components shine.
Tables now dance with a fresh, nimble flair,
Search and sort magic fills the air.
With each commit, my heart beats in cheer—
A code rabbit's celebration is here! 🐰


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac50ae3 and e6e4d3d.

📒 Files selected for processing (20)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/frameworks/[frameworkInstanceId]/components/FrameworkRequirements.tsx (3 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/frameworks/[frameworkInstanceId]/requirements/[requirementKey]/components/table/RequirementControlsTable.tsx (2 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/layout.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/(overview)/page.tsx (2 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/[riskId]/layout.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/[riskId]/page.tsx (3 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/backup-overview/page.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/layout.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/register/layout.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/register/page.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/(overview)/page.tsx (2 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/[vendorId]/layout.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/[vendorId]/page.tsx (3 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/backup-overview/page.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/layout.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/register/layout.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/register/page.tsx (0 hunks)
  • apps/app/src/hooks/use-data-table.ts (1 hunks)
  • apps/app/src/locales/features/frameworks.ts (1 hunks)
  • apps/app/src/locales/features/people.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
vercel Bot temporarily deployed to Preview – comp-portal April 4, 2025 00:26 Inactive
@CLAassistant

CLAassistant commented Apr 4, 2025 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

This branch was successfully deployed

1 active and 1 inactive deployments
Preview – app — e6e4d3dc Deployed Apr 4, 2025 by vercel[bot]
Preview – comp-portal — e6e4d3dc Deployed Apr 4, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants