Claudio/fix hydration by claudfuen · Pull Request #257 · trycompai/comp

claudfuen · 2025-04-03T20:32:20Z

Summary by CodeRabbit

New Features
- Enhanced breadcrumb navigation now clearly highlights the active page across dashboards.
- Updated evidence navigation directs users to a comprehensive view with clearer routing.
- Improved layouts incorporate a more intuitive secondary menu and refined internationalized labels.
Style
- Button padding and overall layout spacing have been adjusted for a more consistent and user-friendly interface.
- Text labels in evidence and policy sections have been streamlined for enhanced clarity.

…ntrols and policies sections

…enu rendering with key prop

…nsistency

…nd hooks for improved functionality and user experience

vercel · 2025-04-03T20:32:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	❌ Failed (Inspect)			Apr 3, 2025 8:40pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
comp-portal	⬜️ Skipped (Inspect)			Apr 3, 2025 8:40pm

CLAassistant · 2025-04-03T20:32:26Z

All committers have signed the CLA.

coderabbitai · 2025-04-03T20:32:27Z

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request makes a series of updates across various dashboard pages. Breadcrumb navigation is enhanced by marking the current page explicitly, while type definitions and parameter names are refined—especially within the evidence domain through the introduction of a new dashboard status type. Several layout components have been removed and replaced, with minor formatting, import path, UI style, and localization adjustments applied across controls, evidence, policies, and related components.

Changes

Files	Change Summary
`.../controls/[controlId]/page.tsx`, `.../policies/[policyId]/page.tsx`, `.../policies/all/page.tsx`, `.../evidence/[evidenceId]/page.tsx`, `.../evidence/all/page.tsx`	Updated breadcrumb navigation to include a `current: true` property and wrapped pages with `PageWithBreadcrumb` for explicit active page indication.
`.../controls/page.tsx`, `packages/ui/src/components/secondary-menu.tsx`, `.../components/policies/policy-overview.tsx`, `.../locales/features/evidence.ts`, `.../locales/features/policies.ts`	Adjusted code formatting, updated logging, modified UI styling (e.g., button padding, spacing in layouts), and refined localization strings.
`.../evidence/(overview)/data/getEvidenceDashboard.ts`, `.../evidence/[evidenceId]/components/EditEvidenceForm.tsx`, `.../evidence/[evidenceId]/components/ReviewSection.tsx`, `.../evidence/[evidenceId]/types.ts`, `.../evidence/[evidenceId]/page.tsx`	Revised type definitions (adding `DashboardStatus`), renamed parameters (switching from `id` to `evidenceId`), and updated interfaces to allow nullable `assignee` and adjust data-fetching logic.
(Deleted only) `.../evidence/(overview)/layout.tsx`, `.../evidence/[id]/layout.tsx`, `.../evidence/list/layout.tsx`; (Added/Updated) `.../evidence/layout.tsx`, `.../policies/layout.tsx`	Removed obsolete layout components and introduced a new evidence layout, with policies layout adjusted (import removal and spacing change) for a refreshed dashboard structure.
`.../risk/register/components/table/RiskRegisterFilters.tsx`, `.../vendors/register/components/VendorRegisterFilters.tsx`, `.../evidence/[evidenceId]/components/EvidenceDetails.tsx`	Updated import paths for shared components (e.g., `AssigneeAvatar`) and added a missing `PageWithBreadcrumb` import to ensure consistency across modules.
`.../evidence/[evidenceId]/PathProvider.tsx`	Changed the back button URL from `/evidence/list` to `/evidence/all` to reflect a broader evidence view.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Router
    participant EvidencePage
    participant getEvidence
    participant Breadcrumb
    participant EvidenceDetails

    User->>Router: Request evidence page (with evidenceId & orgId)
    Router->>EvidencePage: Route with params
    EvidencePage->>getEvidence: Fetch evidence data using evidenceId
    getEvidence-->>EvidencePage: Return evidence data
    EvidencePage->>Breadcrumb: Wrap EvidenceDetails with PageWithBreadcrumb (set current breadcrumb)
    Breadcrumb->>EvidenceDetails: Render evidence details with breadcrumb navigation
    EvidenceDetails-->>User: Display page with updated navigation

Possibly related PRs

Claudio/fix frameworks and requirements #243: Adds a PageWithBreadcrumb component to similar pages, aligning breadcrumb navigation enhancements across the application.

Poem

I’m a rabbit hopping in a code-filled glen,
Breadcrumbs now guide with a “current” sign again.
Types are refined and layouts reborn,
Paths and imports gracefully reformed.
With joyful hops, I celebrate each merge—
CodeRabbit’s tune, a delightful surge!
🐰💻

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4bd1cfa and e051b0f.

📒 Files selected for processing (23)

apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/[controlId]/page.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/page.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/(overview)/data/getEvidenceDashboard.ts (5 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/(overview)/layout.tsx (0 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/[evidenceId]/PathProvider.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/[evidenceId]/components/EditEvidenceForm.tsx (2 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/[evidenceId]/components/EvidenceDetails.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/[evidenceId]/components/ReviewSection.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/[evidenceId]/page.tsx (2 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/[evidenceId]/types.ts (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/[id]/layout.tsx (0 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/all/page.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/layout.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/list/layout.tsx (0 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/[policyId]/page.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/page.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/layout.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/register/components/table/RiskRegisterFilters.tsx (1 hunks)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/register/components/VendorRegisterFilters.tsx (1 hunks)
apps/app/src/components/policies/policy-overview.tsx (2 hunks)
apps/app/src/locales/features/evidence.ts (1 hunks)
apps/app/src/locales/features/policies.ts (1 hunks)
packages/ui/src/components/secondary-menu.tsx (2 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…/fix-hydration

claudfuen added 5 commits April 3, 2025 15:58

refactor: enhance breadcrumb navigation by marking current page in co…

5639ed0

…ntrols and policies sections

refactor: remove unused separator from layout and improve secondary m…

34fdaa3

…enu rendering with key prop

refactor: adjust layout spacing and button padding for improved UI co…

1919755

…nsistency

refactor: update localization strings for evidence and policies features

e4381e8

refactor: restructure evidence feature with new layout, components, a…

c135fc1

…nd hooks for improved functionality and user experience

Merge branch 'main' of https://github.com/trycompai/comp into claudio…

e051b0f

…/fix-hydration

vercel Bot temporarily deployed to Preview – comp-portal April 3, 2025 20:33 Inactive

claudfuen merged commit 04809d3 into main Apr 3, 2025

vercel Bot had a problem deploying to Preview – app April 3, 2025 20:40 Failure

dennisofficial mentioned this pull request Sep 22, 2026

fix(security): P1 sweep - GH-273, GH-257, GH-103, GH-101, GH-100, GH-093, GH-079, GH-078, GH-053, GH-054 #3576

Draft

Navigation Menu

Claudio/fix hydration - #257

Claudio/fix hydration#257
claudfuen merged 6 commits into
mainfrom
claudio/fix-hydration

claudfuen commented Apr 3, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Apr 3, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 3, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

claudfuen commented Apr 3, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel Bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

claudfuen commented Apr 3, 2025 •

edited by coderabbitai Bot

Loading

vercel Bot commented Apr 3, 2025 •

edited

Loading

CLAassistant commented Apr 3, 2025 •

edited

Loading

coderabbitai Bot commented Apr 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)