Skip to content

Claudio/fix hydration - #253

Merged
claudfuen merged 7 commits into
mainfrom
claudio/fix-hydration
Apr 3, 2025
Merged

claudfuen merged 7 commits into
mainfrom
claudio/fix-hydration

Conversation

@claudfuen

@claudfuen claudfuen commented Apr 3, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Introduced breadcrumb navigation on policy detail pages for smoother backtracking.
    • Rolled out a refreshed policies overview page featuring an enhanced data table with dynamic routing and clear loading states.
    • Improved control table navigation to direct users based on their organization context.
    • Streamlined the organization creation form by removing an extra input field.
  • Style

    • Simplified policy URLs and updated dashboard labels (e.g., “All Policies” is now “Policies”) for clearer navigation.

@vercel

vercel Bot commented Apr 3, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 7:45pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
comp-portal ⬜️ Skipped (Inspect) Apr 3, 2025 7:45pm

@claudfuen
claudfuen merged commit 48ced62 into main Apr 3, 2025
@CLAassistant

CLAassistant commented Apr 3, 2025 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Apr 3, 2025 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request applies several cosmetic and structural updates. Many files have been reformatted to use tabs uniformly, and URL paths have been streamlined by removing redundant segments. Several legacy layout components and pages were removed, while new components were introduced for policies overview, including enhanced routing with dynamic organization IDs and breadcrumb navigation. Minor updates were also made to localization strings and form fields, but core functionality remains intact.

Changes

Files Change Summary
apps/app/src/actions/policies/archive-policy.ts, apps/app/src/actions/policies/update-policy-form-action.ts, apps/app/src/actions/schema.ts Reformatted code to use tabs consistently without altering logic.
apps/app/src/actions/policies/update-policy-overview-action.ts, apps/app/src/components/data-table/data-table.tsx, apps/app/src/components/tables/policies/columns.tsx, apps/app/src/components/policies/charts/policies-by-framework.tsx, apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/components/controls-table.tsx Updated routing paths and URL structures by removing redundant segments; introduced new properties (e.g., rowClickBasePath) and hooks for dynamic routing.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/(overview)/layout.tsx, apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/(overview)/components/policies-table.tsx, apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/(overview)/layout.tsx, apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/(overview)/page.tsx, apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/[policyId]/layout.tsx Removed legacy layout and policy overview components to simplify the dashboard structure.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/[policyId]/page.tsx, apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/components/policies-table.tsx, apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/loading.tsx, apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/page.tsx, apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/layout.tsx Introduced new components featuring enhanced routing, breadcrumb navigation, metadata generation, and loading states for policies pages.
apps/app/src/components/forms/create-organization-form.tsx Simplified the organization signup form by removing the "fullName" field and adding an authClient dependency.
apps/app/src/locales/features/policies.ts Updated localization strings, replacing “All Policies” with “Policies”.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant DT as DataTable Component
    participant RH as Row Click Handler
    participant R as Router

    U->>DT: Clicks on a table row
    DT->>RH: Trigger row click event
    RH->>R: Construct URL using rowClickBasePath and row id
    R->>U: Navigate to policy details page
Loading
sequenceDiagram
    participant B as Browser
    participant PP as PoliciesPage
    participant D as Data Fetcher
    participant PB as PageWithBreadcrumb

    B->>PP: Request Policies Page (with locale, policyId, orgId)
    PP->>D: Fetch policies data & metadata
    D-->>PP: Return data and i18n strings
    PP->>PB: Render page with breadcrumb links using orgId
    PB-->>B: Display policies page with navigation breadcrumbs
Loading

Possibly related PRs

  • Lewis/policies final #182: Focuses on cosmetic formatting changes (indentation adjustments) similar to several reformatting updates in this PR.

Poem

I hop through lines of tidy code,
Tabs replacing spaces in a joyful mode.
Breadcrumbs guide my curious trail,
New paths and routes never fail.
Legacy components bid goodbye,
As policies bloom 'neath a clear sky.
Hoppy changes make this rabbit sigh! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20c9dd8 and 9b9c76e.

📒 Files selected for processing (20)
  • apps/app/src/actions/policies/archive-policy.ts (1 hunks)
  • apps/app/src/actions/policies/update-policy-form-action.ts (1 hunks)
  • apps/app/src/actions/policies/update-policy-overview-action.ts (1 hunks)
  • apps/app/src/actions/schema.ts (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/controls/components/controls-table.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/(overview)/layout.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/[policyId]/page.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/(overview)/components/policies-table.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/(overview)/layout.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/(overview)/page.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/[policyId]/layout.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/components/policies-table.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/loading.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/all/page.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/layout.tsx (1 hunks)
  • apps/app/src/components/data-table/data-table.tsx (3 hunks)
  • apps/app/src/components/forms/create-organization-form.tsx (2 hunks)
  • apps/app/src/components/policies/charts/policies-by-framework.tsx (1 hunks)
  • apps/app/src/components/tables/policies/columns.tsx (1 hunks)
  • apps/app/src/locales/features/policies.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This branch had an error being deployed

1 failed and 1 inactive deployments
Preview – app — 9b9c76e5 Deployed Apr 3, 2025 by vercel[bot]
Preview – comp-portal — 9b9c76e5 Deployed Apr 3, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants