Repository navigation
Mariano/evidence improvements #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
...src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/[id]/actions/updateEvidenceDetails.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| "use server"; | ||
|
|
||
| import { authActionClient } from "@/actions/safe-action"; | ||
| import { db } from "@bubba/db"; | ||
| import { Departments, Frequency } from "@bubba/db/types"; | ||
| import { Evidence, EvidenceStatus, Role } from "@prisma/client"; | ||
| import { z } from "zod"; | ||
| import type { ActionResponse } from "@/actions/types"; | ||
|
|
||
| const schema = z.object({ | ||
| id: z.string(), | ||
| department: z.nativeEnum(Departments), | ||
| frequency: z.nativeEnum(Frequency).nullable(), | ||
| assigneeId: z.string().nullable(), | ||
| status: z.nativeEnum(EvidenceStatus).nullable(), | ||
| }); | ||
|
|
||
| export const updateEvidenceDetails = authActionClient | ||
| .schema(schema) | ||
| .metadata({ | ||
| name: "updateEvidenceDetails", | ||
| track: { | ||
| event: "update-evidence-details", | ||
| channel: "server", | ||
| }, | ||
| }) | ||
| .action(async ({ ctx, parsedInput }): Promise<ActionResponse> => { | ||
| const { session } = ctx; | ||
| const { id, department, frequency, assigneeId, status } = parsedInput; | ||
|
|
||
| if (!session.activeOrganizationId) { | ||
| return { | ||
| success: false, | ||
| error: "Not authorized - no organization found", | ||
| }; | ||
| } | ||
|
|
||
| try { | ||
| // Verify the evidence exists and belongs to the organization | ||
| const evidence = await db.evidence.findFirst({ | ||
| where: { | ||
| id, | ||
| organizationId: session.activeOrganizationId, | ||
| }, | ||
| }); | ||
|
|
||
| if (!evidence) { | ||
| return { | ||
| success: false, | ||
| error: "Evidence not found", | ||
| }; | ||
| } | ||
|
|
||
| const payload: Pick< | ||
| Evidence, | ||
| "department" | "frequency" | "assigneeId" | "status" | "lastPublishedAt" | ||
| > = { | ||
| department, | ||
| frequency, | ||
| assigneeId, | ||
| lastPublishedAt: new Date(), | ||
| status, | ||
| }; | ||
|
|
||
| // Update all evidence details in a single operation | ||
| const updatedEvidence = await db.evidence.update({ | ||
| where: { | ||
| id, | ||
| }, | ||
| data: payload, | ||
| }); | ||
|
|
||
| return { | ||
| success: true, | ||
| data: updatedEvidence, | ||
| }; | ||
| } catch (error) { | ||
| console.error("Error updating evidence details:", error); | ||
| return { | ||
| success: false, | ||
| error: "Failed to update evidence details", | ||
| }; | ||
| } | ||
| }); |
136 changes: 0 additions & 136 deletions
136
...p/src/app/[locale]/(app)/(dashboard)/[orgId]/evidence/[id]/components/AssigneeSection.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color inconsistency for "published" status.
There appears to be a inconsistency in the color scheme. The "published" status uses a destructive (likely red) color class, but this seems inappropriate for what appears to be a positive status. In the hex color definitions below, "published" correctly uses a green color.
export const EVIDENCE_STATUS_COLORS = { draft: "bg-[var(--chart-open)]", not_relevant: "bg-[hsl(var(--destructive))]", - published: "bg-[hsl(var(--destructive))]", + published: "bg-[hsl(var(--success))]", } as const;📝 Committable suggestion