Skip to content

Refactor evidence assignee chart for consistent naming conventions #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carhartlewis merged 2 commits into from
Apr 1, 2025
Merged

Refactor evidence assignee chart for consistent naming conventions #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad18507
Refactor evidence assignee chart for consistent naming conventions
carhartlewis Apr 1, 2025
ce40d33
Merge branch 'main' into lewis/ui-fixes
carhartlewis Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...ale]/(app)/(dashboard)/[orgId]/evidence/(overview)/components/evidence-assignee-chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ interface AssigneeData {
published: number;
draft: number;
archived: number;
needs_review: number;
needsReview: number;
}

interface EvidenceAssigneeChartProps {
Expand All @@ -31,7 +31,7 @@ const CHART_COLORS = {
published: "hsl(var(--chart-positive))", // green
draft: "hsl(var(--chart-neutral))", // yellow
archived: "hsl(var(--chart-warning))", // gray
needs_review: "hsl(var(--chart-destructive))", // red
needsReview: "hsl(var(--chart-destructive))", // red
};

export function EvidenceAssigneeChart({ data }: EvidenceAssigneeChartProps) {
Expand Down Expand Up @@ -68,7 +68,7 @@ export function EvidenceAssigneeChart({ data }: EvidenceAssigneeChartProps) {
published: item.published,
draft: item.draft,
archived: item.archived,
needs_review: item.needs_review,
needsReview: item.needsReview,
}));

const chartConfig = {
Expand All @@ -86,7 +86,7 @@ export function EvidenceAssigneeChart({ data }: EvidenceAssigneeChartProps) {
},
needs_review: {
label: t("evidence.status.needs_review"),
color: CHART_COLORS.needs_review,
color: CHART_COLORS.needsReview,
},
} satisfies ChartConfig;

Expand Down Expand Up @@ -130,7 +130,7 @@ export function EvidenceAssigneeChart({ data }: EvidenceAssigneeChartProps) {
<Bar dataKey="published" stackId="a" fill={CHART_COLORS.published} />
<Bar dataKey="draft" stackId="a" fill={CHART_COLORS.draft} />
<Bar dataKey="archived" stackId="a" fill={CHART_COLORS.archived} />
<Bar dataKey="needs_review" stackId="a" fill={CHART_COLORS.needs_review} />
<Bar dataKey="needsReview" stackId="a" fill={CHART_COLORS.needsReview} />
</BarChart>
</ResponsiveContainer>
</ChartContainer>
Expand Down