refactor(frameworks): enhance compliance tracking and visualization - #123
Merged
Merged
Conversation
- Improve FrameworkProgress component with dynamic circular progress indicators - Add useComplianceScores hook to calculate framework compliance metrics - Refactor RequirementStatus component with more detailed compliance tracking - Remove redundant procedure entries in SOC2 control definitions - Optimize policies and evidence requirement compliance calculation - Update usePolicies hook to support more flexible pagination and filtering
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Caution Review failedThe pull request is closed. WalkthroughThis PR introduces a new action for retrieving policies by framework with proper authentication and error handling. In addition, several UI components and hooks have been updated to standardize pagination parameters (switching from Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Action as GetPoliciesByFrameworkAction
participant Auth as AuthActionClient
participant DB as Database
Client->>Action: Request policies for a specific framework
Action->>Auth: Check user authentication
alt Not Authenticated
Auth-->>Action: Return error ("Not authorized")
Action-->>Client: Failure response
else Authenticated
Action->>DB: Execute findMany() query for policies
DB-->>Action: Return policies data or empty result
alt Policies found
Action-->>Client: Success response with policies
else No policies found
Action-->>Client: Failure ("Policies not found")
end
end
sequenceDiagram
participant UI as FrameworkProgress Component
participant Hook as useComplianceScores
participant Policies as usePolicies
participant Evidence as useOrganizationEvidenceTasks
participant Tests as useTests
UI->>Hook: Invoke hook with frameworks
Hook->>Policies: Fetch policies data
Hook->>Evidence: Fetch evidence tasks data
Hook->>Tests: Fetch cloud tests data
Note right of Hook: Compute and memoize compliance scores
Hook-->>UI: Return compliance scores & loading status
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (12)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Data Updates