Repository navigation
feat: validate sandbox environment resource limits and enhance form validation - #976
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
thesujai
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
govindavashishtha,
heerambavi1998,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry,
sr07asthana and
vinit-truefoundry
as code owners
October 6, 2026 12:03
🦋 Changeset detectedLatest commit: 74f1d25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thesujai
commented
Oct 6, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chiragjn
reviewed
Oct 6, 2026
heerambavi1998
approved these changes
Oct 7, 2026
chiragjn
reviewed
Oct 7, 2026
thesujai
enabled auto-merge (squash)
October 8, 2026 03:34
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2c97e34. Configure here.
thesujai
disabled auto-merge
October 8, 2026 05:45
truefoundry-saas
added a commit
that referenced
this pull request
Oct 8, 2026
* feat: validate sandbox environment resource limits and enhance form validation (#976) * feat: validate sandbox environment resource limits and enhance form validation * test: remove sandbox environment validation tests Co-authored-by: Cursor <cursoragent@cursor.com> * Regenerate OpenAPI document and SDKs * feat: add configurable resource limits for sandbox environments and update UI validation * Regenerate OpenAPI document and SDKs * feat: update sandbox environment resource limits and enhance validation in schemas and UI * Regenerate OpenAPI document and SDKs --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: trueforge-dev-bot[bot] <trueforge-dev-bot[bot]@users.noreply.github.com> * feat: enable sandbox environments by default and remove related featu… (#1002) * feat: enable sandbox environments by default and remove related feature flag * refactor: remove sandbox environments feature flag and enable environments UI by default (cherry picked from commit 95f5c5c) * fix: point Environments secrets Learn more at sandbox session docs (#969) * feat: update sandbox documentation and link to secret management details * fix: update Daytona API key permissions in sandbox documentation * fix: remove redundant mention of secret rotations in sandbox documentation (cherry picked from commit 6b42368) --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: trueforge-dev-bot[bot] <trueforge-dev-bot[bot]@users.noreply.github.com> Co-authored-by: Sujai Kumar Gupta <120925871+thesujai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Stricter request validation may reject manifests that previously succeeded (invalid env names, oversized resources), and resource ceilings depend on deployment config.
Overview
Adds server-side caps on sandbox environment CPU, memory, and disk via
SANDBOX_ENVIRONMENT_*_MAX(defaults 32 cores / 64 GiB RAM / 256 GiB disk). PUT create/update now fails validation whenmanifest.resourcesexceed those limits, and the 400 response text mentions resource allocation failures.Tightens sandbox manifest validation in Zod (mirrored in OpenAPI): environment variable keys and secret
envnames must match^[A-Za-z_][A-Za-z0-9_]*$, with min/max lengths on env values;domain_allow_listand the networkingsecretslist get max length/item limits. Resource defaults in the schema now reference shared constants instead of hard-coded numbers.Documents the new env vars in
.env.exampleand records patch releases for@truefoundry/trueforge/ UI in the changeset.Reviewed by Cursor Bugbot for commit 74f1d25. Bugbot is set up for automated code reviews on this repo. Configure here.