Repository navigation
feat: implement timeout for create-turn SSE writes to enhance reliability - #964
Merged
Merged
Conversation
thesujai
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
sr07asthana
as code owners
October 6, 2026 07:50
🦋 Changeset detectedLatest commit: d373aba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chiragjn
approved these changes
Oct 6, 2026
chiragjn
force-pushed
the
bugfix/timeout-in-writesse
branch
from
October 6, 2026 07:58
24fc6f0 to
1cb05f1
Compare
chiragjn
reviewed
Oct 6, 2026
…logic in createTurnsRouter
thesujai
enabled auto-merge (squash)
October 6, 2026 08:21
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 36fba0b. Configure here.
chiragjn
reviewed
Oct 6, 2026
Co-authored-by: Chirag Jain <jain.chirag925@gmail.com>
This was referenced Oct 6, 2026
truefoundry-saas
added a commit
that referenced
this pull request
Oct 6, 2026
* bugfix: show token and cost metrics for failed and cancelled turns (#963) * feat: implement timeout for create-turn SSE writes to enhance reliability (#964) * feat: implement timeout for create-turn SSE writes to enhance reliability * fix: ensure proper handling of SSE stream disconnection and draining logic in createTurnsRouter * Give model fetches a 60s body timeout and shorten the default MCP request timeout to 2 minutes. (#965) Co-authored-by: Cursor <cursoragent@cursor.com> * Regenerate OpenAPI document and SDKs --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: trueforge-dev-bot[bot] <trueforge-dev-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Changes live streaming behavior for create-turn SSE clients (slow consumers may lose the direct stream but can still subscribe), though turn execution and event persistence are intentionally preserved.
Overview
Create-turn streaming now caps how long each SSE write can block using a new
TURN_SSE_STREAM_WRITE_TIMEOUT_MSsetting (default 60s, documented in.env.exampleandconfig.ts).Each
stream.writeSSEin the create-turn handler is wrapped withwithTimeout. If a write hangs or fails (including timeout), the server stops writing to that SSE client, logs disconnect/timeout vs other errors, and maystream.abort()after drain—butdrainTurnEventskeeps dual-writing to the resumable subscription stream, so subscribe/reconnect can still receive events while the turn runs to completion.Reviewed by Cursor Bugbot for commit d373aba. Bugbot is set up for automated code reviews on this repo. Configure here.