refactor: update versioning logic in sandbox environment handling - #919
Merged
Merged
Conversation
thesujai
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
sr07asthana
as code owners
September 29, 2026 13:02
🦋 Changeset detectedLatest commit: 5613666 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
thesujai
commented
Sep 29, 2026
thesujai
commented
Sep 29, 2026
thesujai
requested review from
govindavashishtha,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
September 30, 2026 04:42
debajyoti-truefoundry
approved these changes
Sep 30, 2026
debajyoti-truefoundry
left a comment
debajyoti-truefoundry
left a comment
Contributor
There was a problem hiding this comment.
Keeping approved as we discussed offline
thesujai
force-pushed
the
feat/default-env-controller
branch
from
September 30, 2026 12:18
94400f1 to
c720703
Compare
thesujai
enabled auto-merge (squash)
September 30, 2026 12:33
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 4 potential issues.
There are 7 total unresolved issues (including 3 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e743a85. Configure here.
thesujai
disabled auto-merge
September 30, 2026 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
High Risk
Large API and provisioning redesign (breaking provider status fields, version enum rename) with tenant-wide default env access and async snapshot builds on the critical sandbox path.
Overview
Moves snapshot build readiness off the sandbox provider and onto per-environment versions, with a tenant
defaultenvironment created when a provider is configured.API & product behavior:
ConfiguredSandboxProviderno longer exposes buildstatus; readiness uses environment version status (active→ready). Capabilities/skill gating follows the default environment (plus shared TFY provider / local fallback). Public sandbox-environment routes now include the default in lists, allow any tenant member to readdefault, block deleting it, and acceptSandboxEnvironmentManifestRequeston upsert. New internallist pending/progressendpoints drive a controller that registers or polls Daytona snapshots and updates version rows.Core runtime:
SandboxProvideris generic over provider-specificDaytonaSandboxEnvironment; fresh creates pass snapshot ref, resources, optionalbuild_scriptDockerfile layering, and networking. The harness usesHarnessSandboxinstead of a single global image build on the provider.UI: Sandbox settings drop snapshot sync polling, status badges, and retry; configured providers show as connected only.
Reviewed by Cursor Bugbot for commit 5613666. Bugbot is set up for automated code reviews on this repo. Configure here.