Repository navigation
Conversation
🦋 Changeset detectedLatest commit: e0adf15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chiragjn
force-pushed
the
cj-improve-logging
branch
from
September 30, 2026 04:32
b323c01 to
3e6d6be
Compare
chiragjn
marked this pull request as ready for review
October 7, 2026 05:04
chiragjn
requested review from
bhaveshpatel640,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
October 7, 2026 05:04
chiragjn
requested review from
ramantehlan
and removed request for
bhaveshpatel640,
debajyoti-truefoundry and
sr07asthana
October 7, 2026 05:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Observability and error-message changes only; no auth or persistence behavior changes beyond safer error logging.
Overview
Request-scoped logging adds
request_id(fromx-request-idor minted) on every HTTP request via AsyncLocalStorage and Winston, echoes it on responses, bindsturn_idwhen a turn starts, and propagatesrequest_idfrom schedule dispatch through the controller’s internal API client. Theversionfield is removed from per-line JSON logs.Model and error logging wraps LLM failures as
Model request failed: <provider>/<model>: <reason>(aborts unchanged), deduplicates model errors so onlyAgentThreadlogs once, and tightensextractErrorLogFields: chained cause stacks, no JSON dumps that could leak SDK request bodies (prompts).Tests cover
toStreamError, cause stacks, and prompt redaction.Reviewed by Cursor Bugbot for commit e0adf15. Bugbot is set up for automated code reviews on this repo. Configure here.