Skip to content

fix(sandbox): bound the Daytona calls that requests wait on #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thesujai merged 4 commits into from
Aug 27, 2026
Merged

fix(sandbox): bound the Daytona calls that requests wait on #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
795991c
fix(sandbox): bound the Daytona calls that requests wait on
ethanstoner Aug 27, 2026
66af422
address review: 1 min budget outside the transaction, throw on expiry
ethanstoner Aug 27, 2026
3474dee
minor refactor
thesujai Aug 27, 2026
b91b87e
Merge branch 'main' into fix/daytona-request-timeouts
thesujai Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/daytona-request-timeouts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@truefoundry/trueforge": patch
"@truefoundry/trueforge-core": patch
---

Cap Daytona status-refresh calls at 1 minute so a stalled provider cannot hang request handlers.
14 changes: 11 additions & 3 deletions packages/trueforge/src/sandbox/providerUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
/** Daytona provider construction + persisted build-status refresh (see checkSnapshotStatus). */
import { Daytona, DaytonaError } from '@daytona/sdk';
import { DaytonaSandboxProvider, SANDBOX_IMAGE_URI, type SandboxBuild } from '@truefoundry/trueforge-core/core';
import {
DaytonaSandboxProvider,
SANDBOX_IMAGE_URI,
withTimeout,
type SandboxBuild,
} from '@truefoundry/trueforge-core/core';
import type { Logger } from 'winston';
import configuration from '../config';
import type { ISandboxProviderStore, SandboxProviderRecord } from '../db/sandboxProviderStore';
Expand Down Expand Up @@ -68,6 +73,9 @@ function sandboxStatusFromRecord(record: SandboxProviderRecord): SandboxStatus {
// Daytona deactivates idle snapshots after 14 days; revalidate at 13 to stay a day ahead.
const READY_REVALIDATE_INTERVAL_MS = 13 * 24 * 60 * 60 * 1000;

/** Cap the Daytona round-trip for the refresh, which runs outside a transaction. */
const STATUS_REFRESH_TIMEOUT_MS = 60_000;

export async function checkSnapshotStatus({
store,
tenant_id,
Expand Down Expand Up @@ -99,9 +107,9 @@ export async function checkSnapshotStatus({
let build: SandboxBuild;
if (record.status === 'ready') {
// this is because image may have deactivated
build = await provider.buildImage();
build = await withTimeout(provider.buildImage(), STATUS_REFRESH_TIMEOUT_MS, 'sandbox buildImage');
} else {
build = await provider.getImageBuildStatus();
build = await withTimeout(provider.getImageBuildStatus(), STATUS_REFRESH_TIMEOUT_MS, 'sandbox getImageBuildStatus');
}
const next = toSandboxStatus(build);
const updated = await store.updateSandboxStatus({ tenant_id, ...next });
Expand Down