Repository navigation
fix: map Daytona sandbox secret sync HTTP 4xx failures to 422 - #1012
Merged
Merged
Conversation
thesujai
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
sr07asthana
as code owners
October 8, 2026 12:06
🦋 Changeset detectedLatest commit: 9087056 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
harshil-2096
approved these changes
Oct 8, 2026
thesujai
enabled auto-merge (squash)
October 8, 2026 13:16
harshil-2096
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Low Risk
Narrow change to HTTP status mapping and API documentation for sandbox secret sync errors; no auth or persistence changes.
Overview
Sandbox environment PUT and DELETE secret sync failures from Daytona that return HTTP 4xx are now surfaced as 422 instead of 502, so clients can distinguish provider-side rejection from upstream/gateway failures.
sandboxEnvironmentSecretHttpErrorstill maps Daytona authorization problems to 422 viagetDaytonaAuthorizationErrorMessage, and additionally checks whethererror.causeis aDaytonaErrorwith a 4xxstatusCodebefore falling back to 502. OpenAPI/route descriptions for 422 on create/update and delete were expanded to mention the provider rejecting the secret or deletion.Reviewed by Cursor Bugbot for commit 9087056. Bugbot is set up for automated code reviews on this repo. Configure here.