-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(webapp): dashboard agent — UI #4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kathiekiwi
wants to merge
26
commits into
feat/dashboard-agent-flows
Choose a base branch
from
feat/dashboard-agent-ui
base: feat/dashboard-agent-flows
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
0db2b55
feat(webapp): the dashboard agent's UI
kathiekiwi a73bced
style(webapp): use the agent's own logo in the Help & Feedback entry
kathiekiwi 8e80980
fix(webapp): drop Keep digging once the turn has already kept digging
kathiekiwi ae84b88
feat(webapp): give Cmd-I and the CLI's help link back to Ask AI
kathiekiwi 3c67a9e
test(webapp): give the untrustworthy report fixture the reason field …
kathiekiwi 0ee16b8
fix(webapp): give each copyable task snippet its own SDK import
kathiekiwi 33dee7a
fix(webapp): drop a run diagnosis action that has nowhere to go
kathiekiwi b9ad274
fix(webapp): stop Cmd-J opening Chrome's downloads
kathiekiwi 540d58e
fix(webapp): keep an empty chat open instead of showing a new one
kathiekiwi 16a8b13
docs: say where the docs went now the header button is gone
kathiekiwi 0009817
perf(webapp): keep report blocks out of the investigation winner pass
kathiekiwi 058f114
fix(webapp): give icon-only tooltip buttons an accessible name
kathiekiwi 4d8baca
fix(webapp): stop a zero-limit queue reading as at capacity
kathiekiwi 0a7a0dc
fix(webapp): stop the agent's retry duplicating the failed message
kathiekiwi a80fe5e
docs(webapp): say who Cmd-I actually opens the agent for
kathiekiwi 4ac4554
fix(webapp): time the report sparkline's bars from the report, not th…
kathiekiwi ef10566
fix(webapp): key a repeated view block by its own position
kathiekiwi badd67b
fix(webapp): send a deep-linked question once
kathiekiwi 93af0f1
fix(webapp): stop the URI resolver working after the panel closes
kathiekiwi dd8795f
fix(webapp): announce the composer's counter and name the history button
kathiekiwi 6555d16
fix(webapp): keep the hero's heading reachable when it outgrows the p…
kathiekiwi 4e6f966
fix(webapp): pin the AI-help redirect to the dashboard's own origin
kathiekiwi 0cda43d
fix(webapp): read the agent's page label from the left of the path
kathiekiwi 332a595
fix(webapp): step the composer's live region instead of reading every…
kathiekiwi 71a0a00
fix(webapp): key an investigation's action rows by position, not by kind
kathiekiwi 88efcf7
fix(webapp): treat a transcript re-read that isn't a list as a failed…
kathiekiwi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Keyboard shortcut list advertises an AI shortcut that most users cannot use, and drops the one that works
The keyboard shortcuts panel now lists the AI shortcut as Cmd/Ctrl-J (
TOGGLE_PANEL_SHORTCUT.keyatapps/webapp/app/components/Shortcuts.tsx:67) even though that key only works for the small set of users the dashboard agent is enabled for, and the Cmd/Ctrl-I shortcut that still works for everyone else is no longer listed anywhere.Impact: Users without the new agent see a documented shortcut that does nothing, and no longer see the AI shortcut that does work.
Where the shortcut is registered vs. where it is documented
TOGGLE_PANEL_SHORTCUT(⌘J) is registered only insideDashboardAgentand is disabled whenhasAccessis false (apps/webapp/app/components/dashboard-agent/DashboardAgent.tsx:77-88).hasAccesscomes fromcanAccessDashboardAgentin the environment layout loader, so it is off for most users.ASK_AI_SHORTCUT(⌘I) is still registered app-wide byAskAIRootProvider(apps/webapp/app/components/AskAI.tsx:118-121) whenever Ask AI can open, butShortcuts.tsxno longer lists it.Separately, the new "Chat" group lists "New chat" with
NEW_CHAT_SHORTCUT(apps/webapp/app/components/dashboard-agent/DashboardAgentHeader.tsx:30-34), which is the same ⌘J, so the panel shows two different shortcut names bound to an identical keystroke with no indication that the behaviour is contextual.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.