fix(launch): detect MSIX TradingView by wildcard, not exact package name#366
Open
iamdrsid1 wants to merge 1 commit into
Open
fix(launch): detect MSIX TradingView by wildcard, not exact package name#366iamdrsid1 wants to merge 1 commit into
iamdrsid1 wants to merge 1 commit into
Conversation
Windows launch auto-detection queried `Get-AppxPackage -Name 'TradingView.Desktop'`, but the installed MSIX package name is publisher-prefixed (e.g. `31178TradingViewInc.TradingView`). The exact `-Name` match returned nothing, so `tv launch` / `tv_launch` fell through to the legacy install paths and failed with "TradingView not found on win32" even when TradingView Desktop was installed. Match on a `*TradingView*` wildcard and select the first install whose folder actually contains TradingView.exe. The existing WindowsApps -> local-copy fallback is unchanged. Verified against a real MSIX install (v3.3.0.0) and tests/launch.test.js (7/7 pass; the mock keys on the `Get-AppxPackage` substring, unaffected).
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
tv launch(and thetv_launchMCP tool) fail with "TradingView not found on win32" even when TradingView Desktop is installed as an MSIX/Store package.The MSIX detection in
src/core/health.jsqueries:But the installed package name is publisher-prefixed — e.g.
31178TradingViewInc.TradingView— so the exact-Name 'TradingView.Desktop'match returns nothing. Detection then falls through to the legacy install paths (%LOCALAPPDATA%\TradingView,%PROGRAMFILES%\TradingView, …), none of which exist for a Store install, and throws.Real install observed:
Fix
Match on a
*TradingView*wildcard and select the first install whose folder actually containsTradingView.exe:The
Test-Pathguard avoids picking up an unrelated*TradingView*package that has no launcher. The existing WindowsApps →%LOCALAPPDATA%local-copy fallback (for the "Access is denied" case) is unchanged.Verification
execSynccode path (v3.3.0.0).tests/launch.test.js→ 7/7 pass (the mock keys on theGet-AppxPackagesubstring, so it stays compatible).🤖 Generated with Claude Code