Repository navigation
🐛 fix(api): restore plain tuple results - #365
Merged
Merged
Conversation
The simplint adoption changed two public tuple results into NamedTuple instances and narrowed public annotations. Restore the original return types and annotations for callers that inspect them.
gaborbernat
force-pushed
the
fix/restore-public-tuples
branch
from
November 12, 2026 01:27
30e677c to
2e6e9b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simplint adoption changed
Frontend.create_args_from_folderandFrontend.metadata_from_builtfrom plain tuples to named tuple classes. Callers that inspect exact result types, representations, or annotations receive a different interface. This restores the earlier tuple results and the annotations onSubprocessFrontend.send_cmdandBackendFailed.__reduce__.Narrow lint exceptions keep these public return types and annotations with the simplint hook enabled.
The
FrontendArgsandBuiltMetadataexports added in #361 are removed. Callers using their named fields must unpack the returned tuples.