Fix repeated mount accounting and external SSD deletion guards - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files on a desktop-mounted USB disk under
/run/mediawere blocked as system files. Allow deletion inside an independently mounted disk there, while preserving protection for the mount root, system disks, nested mounts, symlink targets, and ordinary/rundirectories. Read mount points and exceptions from one cached snapshot and recheck the exception on the removal worker.Integrates #36 with its commit ancestry preserved. Mount deduplication now uses kernel device identity (with Btrfs subvolume handling), checks whether the original view is actually visible, and retains duplicate views containing separate mounts. Excluded paths cannot serve as the retained copy; hidden-entry and depth-limited scans keep all views.
Validation:
cargo xtask lintandcargo xtask test: 201 tests passed.scripts/test-linux-mounts.sh: passed in a disposable user/mount namespace with real tmpfs and bind mounts. Covers independent filesystems, duplicate views, nested mounts, media deletion guards, symlinks, and preservation of unmarked files. The deletion test injects the disk classification because an unprivileged namespace cannot mount a block device; mount-table policy is covered separately.Fixes #25.