Fix macOS cmux launches without regressing Unicode arguments - #43
Merged
Merged
Conversation
cmux terminates the foreground process group when AppKit activates an executable reached through the macOS command-line symlink. Restart interactive cmux launches once in their own process group before AppKit starts. Preserve arguments, prevent recursive restarts with an environment marker, and leave non-cmux and non-interactive launches unchanged.
…owups # Conflicts: # crates/disktree-app/src/main.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interactive macOS launches from cmux now start once in a separate process group, preventing cmux from terminating disktree when AppKit takes focus. This integrates #23 while preserving the current Unicode-capable argument parser; non-cmux and noninteractive launches retain their existing behavior.
The original PR's commits are preserved. Native Windows
cargo xtask lintpassed. This PR runs cross-platform CI against current main. The original author reports reproducing the issue and verifying the fix in cmux on macOS.