feat: volume picker dialog and centered alert dialog popups - #41
Merged
Merged
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This PR adds a cross-platform volume picker dialog to quickly switch scan roots across mounted drives and partitions, centers alert dialog popups in the window, and documents the feature in the README.
Key Changes
Volume Picker Dialog (
v/ side panel button)/proc/mounts, filters out pseudo-filesystems (sysfs,proc,tmpfs,cgroup, etc.), and collapses multiple btrfs subvolume mounts sharing the same device to the shortest mount path (e.g./over/home)./System/Volumes/Datadeduplication, and formats disk names.Up/Down),Enterto select and switch scan root,Escapeor backdrop click to dismiss.?help overlay.Centered Alert Dialog Popups
centred_popupinviews.rsto place dialog cards in the middle of the viewport (instead of GPUI's default top-left coordinate).volumes_dialogand the deletion confirmationdelete_dialog.Code Quality & Maintenance
chunks_exact(2)toas_chunks::<2>()to satisfy Clippy 1.98.README.mdkey table and added a Switching volumes section.Verification (Windows)
x86_64-pc-windows-msvc).cargo test --workspace(165 tests passing acrossdisktree-app,disktree-core, andxtask).cargo xtask lint(rustfmt --checkand strict Clippy-D warnings).cargo build --release.