Cancel a scan in progress - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no way to stop a long scan, say a whole disk, short of quitting or opening another folder. Now Escape, or a Cancel button on the scanning panel, stops it.
A cancelled first scan leaves the panel saying it stopped, with the counts so far and a Scan again button (
rworks too). The partial tree is never shown, since it would read like a finished result. Escape during a widening scan (g) stops it and keeps the tree already on screen. An active filter still takes the first Escape. The key bar, the help overlay and the README mention it.with_tree, the test constructor, now cancels the walk thatnewstarts, as its doc comment already says it does. Without that, Escape in the existing key tests cancelled the leftover walk instead of going up a level.Tests: window tests for a cancelled first scan and a cancelled widening. I also tried it by hand on a volume with about 1.1M files.
cargo xtask lintandcargo xtask testpass.