Switching between Size and Files keeps you in the same folder - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Children are sorted by the metric, but switching between Size and Files kept the old crumbs. So if you're inside a folder that is first by size but not by file count, pressing
t(or clicking Files) drops you into whichever sibling now sits at that index, with a different tile selected.This remembers the directory and the selection by path before re-aggregating and finds them again afterwards. It also clears the hover, the crumb menu and any running transition, since those pointed at the old positions too.
Tests: a window test that switches Size, Files and back inside a folder that changes place. On main it ends up in the sibling.
cargo xtask lintandcargo xtask testpass.