fix: require documentId for insert operations across all SDKs - #41
Merged
Merged
Conversation
Make documentId a required field for IngestMemory, InsertDocument, and InsertDocumentsBatch. Add runtime validation that rejects empty documentId. Update tests, example, and integration test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Make documentId a required field in InsertMemoryParams and InsertDocumentParams with validation in validate(). Always include documentId in toMap() output. Update tests, example, and integration test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Make documentId required in InsertMemoryParams (via validate()) and InsertDocumentParams (via required named parameter). Add validation tests. Update example and integration test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change document_id from std::optional<std::string> to std::string in InsertMemoryParams. Add validation and always serialize. Update tests, example, and integration test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add validation for DocumentId in InsertMemoryParams.Validate() and always include it in ToJsonObject(). Update tests, example, and integration test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change document_id from Option<String> to String in InsertMemoryParams, IngestDocumentParams, and BatchDocumentItem. Add validation in insert_memory, ingest_document, and ingest_documents_batch. Update tests and examples. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
documentIdis a non-empty string forinsertMemory,insertDocument, andinsertDocumentsBatchdocumentIdin request bodies (no longer optional/omittable)SDKs updated
fix(sdk-golang): require documentId for insert operationsfix(sdk-java): require documentId for insert operationsfix(sdk-dart): require documentId for insert operationsfix(sdk-cpp): require documentId for insertMemoryfix(sdk-csharp): require documentId for insertMemoryfix(sdk-rust): require documentId for insert operationsTest plan
go test ./...— passed./gradlew test— BUILD SUCCESSFULdart test— 52 passeddotnet test— 52 passedcargo test— 10 passed🤖 Generated with Claude Code