You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the PR. Have you tested this change on all supported platforms, especially macOS, Windows, Linux, and the web build?
One concern is backward compatibility with the existing config path. For example, on macOS the old userdir.GetConfigHome() path appears to be ~/Library/Preferences, while os.UserConfigDir() uses ~/Library/Application Support. This may cause existing users' connections and preferences to no longer be found after upgrading.
Could you confirm whether the old paths are still supported, or add a migration/fallback mechanism for existing config files?
Could you confirm whether the old paths are still supported, or add a migration/fallback mechanism for existing config files?
I've added the migration logic, and the configuration directories on Windows and Linux should now be consistent with the previous ones (no compatibility issues).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
github.com/vrischmann/userdirpackage has been archived. We can drop this dependency and leverage the standard library's os package instead.