Trading API headers issue

There's an issue with Trading API and maybe with the configs themselves. When building headers, some values are being pulled from config and Connection parameters. As we don't need anything other than appid and token, other values (such as devid, keys/certs) are not required. The issue is that these values are None in config, and when config.get(val, default) is being called, it returns None. Later the header check fails. There's probably a better way to deal with this, but as a hotfix one can use:

/ebaysdk/config.py

def get(self, cKey, defaultValue=None):
    val = self.values.get(cKey, defaultValue)
    if val is None:
        return defaultValue
    return val

Another quality of life feature could be some sort of automatic value parsing

/ebaysdk/response.py

def _setattr(self, name, value, datetime_nodes):
if name.lower() in datetime_nodes:
    try:
        ts = "%s %s" % (value.partition(
            'T')[0], value.partition('T')[2].partition('.')[0])
        value = datetime.datetime.strptime(ts, '%Y-%m-%d %H:%M:%S')
    except ValueError:
        pass

if value == 'true':
    value = True
elif value == 'false':
    value = False
else:
    try:
        value = float(value)
        if value % 1 == 0:
            value = int(value)
    except:
        pass


setattr(self, name, value)

Navigation Menu

Repository navigation

Trading API headers issue #376

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Trading API headers issue #376

Description

Activity

slonopot commented on Apr 20, 2023

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions