GML-2200 Release 2.0.5 - #288
Open
chengbiao-jin wants to merge 6 commits into
Open
chengbiao-jin wants to merge 6 commits into
chengbiao-jin wants to merge 6 commits into
Conversation
- Reuse a connection after the event loop it first ran on has closed. - Share one connection between threads that each run their own loop, without one closing the session another is using. - Release sessions belonging to a closed loop instead of leaking them.
- Installing queries no longer holds the connection open for the whole compile, which could be dropped by an intermediate gateway. - Callers that choose not to wait now receive the request id to poll, rather than a completion message.
- Choose the agentic or classic engine, and the variant within it. - Choose which fields the response returns beyond the answer. - Asking a question with no options given behaves exactly as before.
- Retrieve a vertex whose id contains a percent sign. - Retrieve an untyped vertex whose id contains an ampersand or a hash.
- Bump the version to 2.0.5. - Correct the minimum supported Python version to 3.9; installing on 3.8 previously succeeded and then failed on import. - Correct the test setup documentation, which claimed the script drops every graph on the instance rather than only its own.
- Test connection settings can be overridden with TG_TEST_<KEY> variables, so a real instance no longer needs its address or credentials written into a tracked config file.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix async connection use across event loops (GML-2183)
Submit query installation asynchronously (GML-2201)
request instead of a completion message. This is the default for
async connections.
Add chat engine and response field selection to AI queries (GML-2202)
Fix vertex id escaping for installed queries (GML-2203, GML-2204)
Prepare the 2.0.5 release (GML-2200)
from 3.8. Installing on 3.8 previously succeeded and then failed on
import.
Point tests at a live instance through TG_TEST_ environment
variables, so its address and credentials need not be written into a
tracked config file
Verified against a live TigerGraph 4.2.2 instance: the whole suite was run
with no tests skipped. Every remaining failure also occurs on master — each
differing suite was re-run interleaved against master and matched — except
the GDS suites, which need
torchand the Cora and hetero datasets that thisinstance does not have. The repo runs no CI, so none of this ran automatically.