GML-2182, GML-2194..2198: data-isolation, access-control and ingest fixes for 2.0.3 - #67
Open
chengbiao-jin wants to merge 6 commits into
Open
chengbiao-jin wants to merge 6 commits into
chengbiao-jin wants to merge 6 commits into
Conversation
- Conversation history is no longer retained on the server between calls, so concurrent callers no longer receive each other's previous questions and answers as context - Callers supply prior turns on the request; the most recent are used - Requests that send no turns are answered without prior context - Update the demo notebook to carry its own conversation Refs: GML-2194
- A PDF or image that cannot be extracted no longer becomes a document whose text is the failure notice, so no placeholder content reaches the knowledge graph or turns up in answers - Such a file is reported as failed with the reason; other files in the same upload still process normally - Failure messages name the file and the remedy, keeping parser detail in the server log Refs: GML-2195
- Tables in a .docx are read and rendered in place, so the figures they hold reach the knowledge graph and can be cited; previously only the paragraphs around them were ingested and the table vanished silently - Tables nested inside a cell are included, and a pipe or line break in a cell no longer breaks the rendered row - Legacy .doc is reported as unreadable with a pointer to .docx, instead of being listed as supported and ingested as a note about itself - An empty spreadsheet or an unreadable file type is reported as a failure rather than ingested as placeholder text Refs: GML-2196
- The document-retrieval endpoint returned matching content without checking the caller; it now rejects anyone who cannot access the graph named in the request - Search runs against the graph named in the request instead of the configured default graph - A request with no credentials is rejected rather than failing as a server error Refs: GML-2197
- Contextual (sibling-chunk) search received the hypothetical-answer and question-expansion options in each other's place on every call, so asking for one applied the other; they select different search strategies rather than variations of one - Requests that set neither option, which is all chat traffic, were unaffected Refs: GML-2198
- Rebuilds started from a token sign-in no longer fail as if the graph did not exist - An invalid token is rejected as an authentication failure instead of a server error Refs: GML-2182
chengbiao-jin
force-pushed
the
GML-2194-2198-2.0.3-fixes
branch
from
September 24, 2026 23:41
37084b6 to
0e614e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six fixes for the 2.0.3 release, one commit each. Analysis and implementation detail are in the linked tickets.
.docxuploads are extracted; legacy.docis reported as unsupportedRequest and response shapes are unchanged; some responses gain fields.
Review order matters — GML-2196 builds on a type introduced in GML-2195.
Tests — seven new modules plus updated route tests; each commit passes its own tests.