Audio: EQ FIR: Changes for IPC4 - #6969
Merged
Merged
Conversation
singalsu
force-pushed
the
eqfir_ipc4_fixes
branch
from
January 20, 2023 09:31
5ca57a5 to
e2f32e7
Compare
singalsu
changed the title
singalsu
force-pushed
the
eqfir_ipc4_fixes
branch
from
January 20, 2023 10:16
e2f32e7 to
180f340
Compare
singalsu
marked this pull request as ready for review
January 20, 2023 10:17
singalsu
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
January 20, 2023 10:17
lyakh
reviewed
Jan 23, 2023
lyakh
left a comment
lyakh
left a comment
Collaborator
There was a problem hiding this comment.
looks good! Just a couple of minor comments
The unused single frame processing functions can be removed to save code size. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The channels count need to be retrieved from source buffer. The mod->stream_params->channels is not available in IPC4. Frame_count calculation is also simplified. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This can be done once at eq_fir_process() to save code size. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The FIR processing cores are computing multiple of two frames sizes so the align constraint can be set to prevent EQ process to be called with odd frame counts. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Add determined stream channels count to info trace to better understand possible error in coefficients blob initialization. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch contains the main changes for IPC4. The FIR function need to be selected in prepare() with mod->priv.cfg.base_cfg.audio_fmt information. The eq_fir_prepare() function must call in IPC4 the params() function to get stream parameters from same struct to set the sink buffer parameters. Some comp_info() traces are changed to comp_dbg() to reduce trace verbosity. This patch also includes an optimization to select the eq_fir_passtrough() function when all of the channel filters in blob are set to bypass. The block copy function is more efficient than per channel FIR bypass. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
eqfir_ipc4_fixes
branch
from
January 24, 2023 13:28
180f340 to
aab3f4a
Compare
lyakh
approved these changes
Jan 25, 2023
Merged
lgirdwood
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See descriptions in each commit.