scattered fixes and cosmetic improvements - #11110
Open
lyakh wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small, mostly cosmetic cleanups in IPC4 helper/handler code while slightly simplifying the user-space LL MOD_INIT_INSTANCE handling, as part of the broader userspace LL scheduling work in #10945.
Changes:
- Normalize formatting of a handful of IPC logging and helper calls (line wrapping / argument layout).
- Simplify
SOF_IPC4_MOD_INIT_INSTANCEhandling in the userspace-LL path by using a typed pointer to the incoming message rather than copying into a local struct. - Add an include in
pipeline-graph.c(currently duplicated in-file; see review comment).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ipc/ipc4/helper.c | Cosmetic formatting adjustments to log calls and helper invocations. |
| src/ipc/ipc4/handler-user.c | Streamlines userspace-LL module init handling by reusing the message buffer as a typed view. |
| src/ipc/ipc-helper.c | Cosmetic formatting changes to buffer/pipeline helper calls and log lines. |
| src/audio/pipeline/pipeline-graph.c | Adds an LL scheduling domain include (currently duplicated). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Use a type-cast instead of a memcpy() to obtain struct ipc4_module_init_instance data. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Join several needlessly broken lines. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #10945