Repository navigation
fix: settings model container and spaces UI - #127
Merged
Merged
Conversation
kenenisa
requested changes
Sep 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical SwiftData connectivity issue where the Settings window couldn't access the main browser's database. The solution centralizes database configuration and improves the Spaces settings UI with better visual design and organization.
- Fixed Settings window SwiftData context to connect to the same database as main browser
- Centralized ModelContainer configuration to eliminate code duplication
- Enhanced Spaces settings UI with improved layout, styling, and organization
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ora/oraApp.swift | Added shared ModelContainer for Settings window with fallback UI |
| ora/OraRoot.swift | Refactored to use centralized database configuration |
| ora/Modules/Settings/Sections/SpacesSettingsView.swift | Improved UI layout with better styling and organization |
| ora/Common/Extensions/ModelConfiguration+Shared.swift | New centralized database configuration utilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kenenisa
approved these changes
Sep 28, 2025
kenenisa
pushed a commit
that referenced
this pull request
Sep 29, 2025
* fix: settings model container * fix: space settings ui more digestible * fix: move extension file to extension directory * fix: refactor retry of container creation failure * fix: allow left and right settings view in spaces to scroll independently
kenenisa
pushed a commit
that referenced
this pull request
Oct 6, 2025
* fix: settings model container * fix: space settings ui more digestible * fix: move extension file to extension directory * fix: refactor retry of container creation failure * fix: allow left and right settings view in spaces to scroll independently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The Settings window wasn't connected to the same SwiftData database as the main browser:
modelContextSolution
Fixed SwiftData Context
Added shared
ModelContainerto Settings window that connects to the same database. Settings now properly displays all created containers/spaces.Centralized Configuration
Created
ModelConfiguration+Shared.swiftto eliminate code duplication betweenOraRoot.swiftandoraApp.swift. Both files now use the same database configuration, providing a single source of truth for schema, database path, and container creation.Spaces UI Enhancement
Made the Spaces settings tab look a little cleaner
Before
After