Skip to content

Regression: Types of property hydrate are incompatible in renderHook options #1312

Closed

Description

@samettttt
  • @testing-library/react version: 15.0.4
  • Testing Framework and version: vitest 1.5.0
  • DOM Environment: jsdom

Relevant code or config:

import { RenderHookOptions, renderHook } from '@testing-library/react';

export const renderHookHelper = <TProps, TResult>(
    callback: (props: TProps) => TResult,
    options: RenderHookOptions<TProps> = {},
) => {
    // ...
    // bunch of code
    // ...

    return renderHook(callback, { ...options });
};

What you did:

We use the RenderHookOptions type for a parameter in a helper function where we call renderHook.

What happened:

Screenshot 2024-04-24 at 20 49 01

Reproduction:

https://stackblitz.com/edit/rtl-template-22bvkk?file=src%2FApp.test.tsx

Problem description:

We can't simply use the RenderHookOptions type in our helper function. There are workaround to this problem but I thought that maybe this change was not intentional.

Activity

  1. self-assigned this
    on Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions