Handle partial E2E dependency initialization during teardown - #3950
Open
zerogravit1 wants to merge 2 commits into
Open
zerogravit1 wants to merge 2 commits into
zerogravit1 wants to merge 2 commits into
Conversation
|
@zerogravit1 is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
zerogravit1
force-pushed
the
fix/e2e-lifecycle-cleanup
branch
from
September 29, 2026 02:22
701634d to
761f8ef
Compare
zerogravit1
marked this pull request as ready for review
September 29, 2026 02:27
Alex-Tideman
approved these changes
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Fixes #3915.
E2E teardown currently assumes that all dependencies completed initialization.
If setup fails after some dependencies have been created or started, teardown can
throw while attempting to clean up an uninitialized dependency. This can obscure
the original setup failure and prevent later cleanup, including shutdown of the
Temporal dev server.
This change makes codec server shutdown safe before start and makes UI server
cleanup tolerate partial initialization.
Screenshots (if applicable) 📸
N/A
Design Considerations 🎨
The change is intentionally limited to lifecycle cleanup behavior rather than
changing the overall E2E setup sequence.
Testing 🧪
How was this tested 👻
Added codec lifecycle coverage for:
Also reproduced the partial setup failure by temporarily removing the UI assets.
Before the fix:
After the fix:
A clean E2E run also completed successfully.
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Build the E2E assets normally.
Temporarily move the UI assets:
mv server/ui/assets server/ui/assets.bakRun:
pnpm test:e2e tests/e2e/schedules.spec.ts --project="chromium desktop"Confirm the original UI build failure is reported without a secondary teardown error.
Confirm no Temporal process remains listening on ports 7233/7234.
Restore the assets.
Checklists
Draft Checklist
Opening as draft for feedback on the cleanup approach.
Issue(s) closed
Fixes #3915
Docs
Any docs updates needed?
No.