Set up test coverage - #166
Merged
Merged
Conversation
mrliptontea
commented
Sep 4, 2026
mrliptontea
commented
Member
- Set up test coverage
- Add additional tests, to improve test coverage
mrliptontea
force-pushed
the
coverage
branch
from
September 7, 2026 12:25
3acb117 to
02c5a25
Compare
mrliptontea
force-pushed
the
coverage
branch
from
September 7, 2026 12:50
02c5a25 to
d998c2c
Compare
mrliptontea
commented
Sep 7, 2026
| $graph->add_literal_triple($subject, FOAF_NAME, 'Anne Example'); | ||
|
|
||
| $this->tripod->saveChanges(new ExtendedGraph(), $graph); | ||
| $tripod2->saveChanges(new ExtendedGraph(), $graph); |
Member
Author
There was a problem hiding this comment.
Ensures source data is present - previously this test would pass because another would insert the data, but adding executionOrder="depends,defects" to PHPUnit config changes that.
Comment on lines
+1160
to
+1162
| if (strpos($collectionName, 'system.') === 0) { | ||
| continue; | ||
| } |
Member
Author
There was a problem hiding this comment.
system.indexes could be present from other tests, tripping this up.
Comment on lines
-50
to
-51
|
|
||
| $this->loadResourceDataViaTripod(); |
Member
Author
There was a problem hiding this comment.
Removed from setUp so tests can call it and alternatively clean up before
stephenrob
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.