Repository navigation
Make font weight inherit in preflight - #8078
Merged
Merged
Conversation
Contributor
|
Thanks! I think we can call this a bug fix since the behavior is currently inconsistent across browsers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds the font-weight inherit as the preflight to normalize it across browsers.
In our code we set a default font-weight of 500 on the body along other default font properties. However, for button elements, the font-weight is inherited by default on Chrome and Firefox:
However, on Safari, the font-weight is not inherited and default to 400:
This PR ensure the button is properly normalized so that everything renders consistently across browsers.