Repository navigation
Allow for custom properties in rgb, rgba, hsl and hsla colors - #7933
Merged
Merged
Conversation
RobinMalfait
commented
Mar 24, 2022
Comment on lines
+5
to
+7
| let VALUE = /(?:\d+|\d*\.\d+)%?/ | ||
| let SEP = /(?:\s*,\s*|\s+)/ | ||
| let ALPHA_SEP = /\s*[,/]\s*/ |
Contributor
Author
There was a problem hiding this comment.
Only changes here are moving from string-based regex to an actual regex. Makes it a bit easier to reason about because of the otherwise confusing double escapes.
Later you can use SEP.source to get the string based value again if you want to compose it inside a RegExp.
Contributor
|
Hi @RobinMalfait , I am not sure if this is because I am using a prefix (I found a lot of issues when using prefix), but on the latest insider version, this does not work and no CSS is generated: I am still required to use the color prefix as shown below: Is there a known incompatibility with prefix? |
Contributor
|
I am opening an issue as it will be easier to track :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will allow for custom properties to exist inside the
rgb,rgba,hslandhslacolor functions.This is useful if you want to do things like this:
Previously this didn't work and wouldn't generate anything because we didn't correctly parse this as a color. You could force it by using a color type hint:
The only issue with this is that it doesn't compose well with the opacity modifiers. This should now be fixed, where this:
... resolves to:
While the class itself looks strange, it is valid and works as aspected: https://play.tailwindcss.com/ImyUO7n2XU?file=css
Fixes: #7909