Invalidate context when main css changes - #7626
Merged
thecrypticace merged 4 commits intoFeb 25, 2022
Merged
Conversation
thecrypticace
force-pushed
the
fix/context-invalidation-on-content-change
branch
3 times, most recently
from
February 25, 2022 13:36
83d7e9e to
3cfb703
Compare
thecrypticace
marked this pull request as ready for review
February 25, 2022 14:59
thecrypticace
force-pushed
the
fix/context-invalidation-on-content-change
branch
from
February 25, 2022 15:40
db4968d to
9121d40
Compare
thecrypticace
force-pushed
the
fix/context-invalidation-on-content-change
branch
from
February 25, 2022 15:45
9121d40 to
dc7b00a
Compare
thecrypticace
force-pushed
the
fix/context-invalidation-on-content-change
branch
from
February 25, 2022 17:57
0504e94 to
e960034
Compare
thecrypticace
force-pushed
the
fix/context-invalidation-on-content-change
branch
from
February 25, 2022 18:03
e960034 to
7aea65f
Compare
Contributor
|
@thecrypticace you will make a lot of Tailwind CSS users happy 🥳 I've try to remove Sass from my workflow and it's pretty good too. Thanks a lot |
|
Thank you for your hard work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we can't rely on preprocessors tracking imports as dependencies through PostCSS the only way we can reliably reuse the context is by using a hash of the CSS tree. This will let us invalidate the context when using tools like Sass with imports that contain
@layerdirectives.Fixes #4838