Repository navigation
Preserve source maps for generated CSS - #7588
Merged
Merged
Conversation
thecrypticace
force-pushed
the
fix/apply-source-maps
branch
2 times, most recently
from
February 23, 2022 16:20
e0c71bf to
ab0c9db
Compare
thecrypticace
force-pushed
the
fix/apply-source-maps
branch
from
February 23, 2022 16:21
ab0c9db to
3f7aae3
Compare
thecrypticace
marked this pull request as ready for review
February 23, 2022 16:24
Contributor
|
@thecrypticace do you have an idea when it can be released? |
Contributor
Author
|
We moved some stuff around today just so we could get a patch release out with a whole slew of bug fixes! You can upgrade to v3.0.24! |
This was referenced May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source maps were not preserved for CSS in many cases because:
This should fix all of those and we now have tests to verify that source maps are properly generated as well.
Apply source maps could be better. For instance it may make sense that the individual rules generated for
@apply text-black font-monowould point to the columns fortext-blackandfont-monorespectively. However, that is a lot of bookkeeping for not much gain. Having them all point to the apply line that generated them seems like a reasonable tradeoff.Fixes #7583
Fixes #5043
Closes #7369