Repository navigation
Correctly parse and prefix animation names with dots - #7163
Merged
thecrypticace merged 8 commits intoMar 1, 2022
Merged
Conversation
Contributor
|
Hey thanks! I'm having a bit of a hard time seeing the issue really clearly though — there's gotta be a test we could write that would fail without this being merged that would make it clearer? Is the issue just that things break when you include a |
Contributor
|
The issue is that it would generate the following invalid CSS as the dot has to be escaped and not the 5: @keyframes zoom-1.\35 {
to {
transform: scale(1.5);
}
}
.animate-zoom-1\.5 {
animation: zoom-1.\35 2s;
}Additionally, when a prefix was configured the behavior was even weirder: @keyframes tw-zoom-1.tw-5 {
to {
transform: scale(1.5);
}
}
.tw-animate-zoom-1\.5 {
animation: tw-zoom-1.tw-5 2s;
} |
Contributor
|
Appreciate you taking the time to figure this one out! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7149.
Adds prefix alone to animation names, such that the parser does not run on the rest of the identifier, possibly damaging class names like "zoom-1.5".
Although tests still pass, care must be taken as this effectively disables previous [albeit similar] behavior.