Skip to content

Replace cosmiconfig with lilconfig - #6038

Merged
bradlc merged 3 commits into
tailwindlabs:masterfrom
TrySound:lilconfig
Mar 1, 2022
Merged

bradlc merged 3 commits into
tailwindlabs:masterfrom
TrySound:lilconfig

Conversation

@TrySound

Copy link
Copy Markdown
Contributor

It's already replaced in postcss-load-config

See https://github.com/postcss/postcss-load-config/blob/main/package.json#L26

@adamwathan

Copy link
Copy Markdown
Contributor

Hey sorry any chance you could rebase this to resolve the conflicts? Then can definitely merge 👍🏻 Thank you!

@TrySound

Copy link
Copy Markdown
Contributor Author

Hey, will rebase in a couple of hours! Btw having more ideas how to improve install size.

@TrySound

Copy link
Copy Markdown
Contributor Author

Done

@bradlc bradlc self-assigned this Mar 1, 2022
@bradlc

bradlc commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Hey @TrySound, thanks for updating the PR! What's the reason for updating the postcss version in package.json?

@thecrypticace

Copy link
Copy Markdown
Contributor

it probably happened automatically and wasn't noticed. NPM is doing the same thing for me any time I npm install a new dependency into the tailwindcss repo. I have absolutely no idea why.

@TrySound

TrySound commented Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

yeah, npm does a bad job with lockfiles. Yarn and pnpm are more stable.

@bradlc

bradlc commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Ah I see, all good 👍 Thanks again!

@bradlc
bradlc merged commit f31c4ee into tailwindlabs:master Mar 1, 2022
@MichaelDeBoey

Copy link
Copy Markdown
Contributor

@adamwathan @bradlc This would be a breaking change, as files without an extension are now handled differently
https://github.com/antonk52/lilconfig#difference-to-cosmiconfig

Schermafbeelding 2022-03-06 om 22 06 54

@TrySound

TrySound commented Mar 6, 2022

Copy link
Copy Markdown
Contributor Author

postcss-load-config migrated in 3.1.

@MichaelDeBoey

Copy link
Copy Markdown
Contributor

@TrySound They provide the yaml loaders themselves instead, so for them it's not breaking at all

Since we don't do that in this PR, it's a breaking change for Tailwind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants