Update settings_2 for #342 fix + small refactor - #46
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #342 and refactors element selection in the settings tests to use more specific elementByIdWithin queries instead of array indexing with elementsById. The changes improve test reliability by targeting elements within specific parent containers rather than relying on DOM order.
Key changes:
- Fixed assertion for Bitcoin unit display to expect '0.00000000' instead of '0'
- Refactored element queries to use
elementByIdWithinwith parent-child relationships - Moved
unitRowquery to occur after navigation actions complete
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| await doNavigationClose(); | ||
|
|
||
| await expect(await elementsById('MoneyFiatSymbol')[1]).toHaveText('€'); | ||
| await expect(fiatSymbol).toHaveText('€'); |
There was a problem hiding this comment.
The fiatSymbol element was queried at the beginning of the test before any currency changes. After changing the currency to EUR, the element reference may be stale and not reflect the updated currency symbol. Re-query the element after the currency change to ensure the assertion validates the current DOM state.
No description provided.