feat: add Passport hardware wallet support - #138
Open
ben-kaufman wants to merge 2 commits into
Open
Conversation
ben-kaufman
requested review from
coreyphillips and
ovitrif
and removed request for
coreyphillips
August 25, 2026 13:18
ovitrif
reviewed
Aug 25, 2026
ovitrif
left a comment
Collaborator
There was a problem hiding this comment.
UrDecoder.receive wipes fountain progress on every invalid camera frame, including unreadable frames that fail bytewords checksums. Animated Passport QR scans produce those frames routinely, so pairing and signed-PSBT return cannot complete under ordinary camera conditions. Keep the current state on parse and checksum failures, and reset only when a successfully parsed part belongs to a different UR stream.
ben-kaufman
force-pushed
the
feat/hardware-wallet-core
branch
from
August 25, 2026 17:37
37f6351 to
55e904a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
crypto-psbtencoding, with Passport generic JSON account-export parsing.0.5.7and regenerate the Swift, Kotlin/Android, and Python bindings and native artifacts.Preview
N/A — Core/FFI change.
QA Notes
crypto-psbt, firmware signing, signed-response decoding, and final transaction verification.cargo test modules::hardware_wallet— 1 passed.cargo test modules::ur— 10 passed.cargo test modules::onchain::psbt— 4 passed.cargo clippy --all-targetspassed.