Skip to content

Create and implement HighlightLabel in Passphrase screen - #46

Merged
ovitrif merged 9 commits into
masterfrom
feat/highlight_label
Mar 11, 2025
Merged

Create and implement HighlightLabel in Passphrase screen#46
ovitrif merged 9 commits into
masterfrom
feat/highlight_label

Conversation

@jvsena42

@jvsena42 jvsena42 commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

FIGMA - Handoff 54

Component

advanced.webm

@jvsena42 jvsena42 self-assigned this Mar 10, 2025
@jvsena42 jvsena42 mentioned this pull request Mar 10, 2025
Closed
@jvsena42
jvsena42 requested a review from ovitrif March 10, 2025 17:27
@jvsena42
jvsena42 marked this pull request as ready for review March 10, 2025 17:27
@jvsena42

jvsena42 commented Mar 10, 2025

Copy link
Copy Markdown
Member Author

@ovitrif after merge, you can mark this item as complete too

@jvsena42 jvsena42 changed the title Feat/highlight label Create and implement HighlightLabel in Passphrase screen Mar 10, 2025
ovitrif
ovitrif previously approved these changes Mar 10, 2025
View reviewed changes

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🎉

PS. At some point we'll need to cleanup in the project structure the confusion between packages: ui.components and ui.shared

May I suggest for the now to move HighlightLabel to ui.components package?! Lately I tried to move away from shared for components, and most of what's still left in it are components that are only in debug-related UIs.

Thanks in advance!

@jvsena42

jvsena42 commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

Nice work! 🎉

PS. At some point we'll need to cleanup in the project structure the confusion between packages: ui.components and ui.shared

May I suggest for the now to move HighlightLabel to ui.components package?! Lately I tried to move away from shared for components, and most of what's still left in it are components that are only in debug-related UIs.

Thanks in advance!

Agree

@jvsena42

jvsena42 commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

@ovitrif done

ovitrif
ovitrif approved these changes Mar 11, 2025
View reviewed changes

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work on this @jvsena42, merging 🚀

@ovitrif
ovitrif merged commit 1149c84 into master Mar 11, 2025
@ovitrif
ovitrif deleted the feat/highlight_label branch March 11, 2025 10:25
@claude claude Bot mentioned this pull request Nov 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovitrif ovitrif ovitrif approved these changes

Assignees

@jvsena42 jvsena42

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Review and Adjust (Secure with passphrase) Flow

2 participants

@jvsena42 @ovitrif