Repository navigation
Question: How would you make the sample tab component to use svg icons instead of font icons #715
Description
I'm running into a conceptual problem and trying to figure out how to structure my code. I tried using the slack but seemed to get no response.
So I'll try to simplify my question here, how would one modify the sample tab component to use SVG icons instead?
Activity
VictorGaiva commentedon Nov 6, 2023
I believe that 'icon' should've been a
slot, instead of just:string.deviprsd commentedon Nov 7, 2023
@VictorGaiva The slot doesn't propagate to
Tabbecause theTabItemis considered a slot itself.TabItemwould have access toiconslot but notTab. This doesn't work very well when you have to conditional rendering asTabis doing, seems like one way is passing attributes back toTabItemto generate a button and then one to generate its contents. The whole logic then shifts toTabItemdougw-bc commentedon Nov 7, 2023
I would consider the approach taken with new phx generated
CoreComponents.icon/1, which embeds the svg into css, and makes it trivial to use as if it was a font based icon.deviprsd commentedon Nov 10, 2023
@dougw-bc I ended up that route, now I just want to see if something like this should be possible 😄