Repository navigation
Conversation
When a user swipes to dismiss the Stripe checkout sheet before the JS stripe_checkout_abandon message fires, the fallback abandon path now uses the product ID from stripeCheckoutStart instead of an empty string. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit b0882a8.
…attern Add PaywallPageViewInfo struct to expose pageNodeId, pageIndex, pageName, and navigationType to SDK consumers. Align pageView message decoding with the try?/if-let pattern used by all other PaywallMessage cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace PaywallPageViewInfo with public PageViewData, used for decoding, internal tracking, and the public delegate event. Removes redundant field-by-field passing throughout the chain. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add CodingKeys to map from JSON "type" to navigationType property. Document all possible values: entry, forward, back, auto_transition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
feat: add event sending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paywall_page_viewevent that carries page view information.Test plan
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.swiftlintin the main directory and fixed any issues.🤖 Generated with Claude Code
Greptile Summary
Adds a
paywall_page_viewevent that fires whenever a user navigates to a page in a multi-page paywall, carryingPageViewData(page node ID, flow position, navigation type, time on previous page, etc.). Also introduces apresentationIdonPaywall/PaywallInfo— assigned asUUID().uuidStringat fetch time ingetRawPaywall— to correlate all events (open, page views, close) within a single paywall presentation lifecycle.Confidence Score: 5/5
Safe to merge — all remaining findings are P2 style suggestions with no correctness or data-integrity impact
Implementation is clean and consistent with every existing event-tracking pattern. All files align, tests are comprehensive, and the presentationId lifecycle is well-modelled. The only finding (navigationType as String vs enum) is a style improvement that does not affect runtime behaviour.
No files require special attention
Important Files Changed
Sequence Diagram
sequenceDiagram participant JS as JS Paywall participant WV as SWWebView participant MH as PaywallMessageHandler participant SW as Superwall.shared participant AN as Analytics JS->>WV: page_view JSON message WV->>MH: handle(.pageView(data)) MH->>MH: guard delegate, capture delegate.info MH->>SW: Task { track(PaywallPageView) } SW->>AN: paywall_page_view event Note over AN: params include page_node_id,<br/>flow_position, navigation_type,<br/>presentation_id, paywall_identifierPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "Merge pull request #448 from superwall/c..." | Re-trigger Greptile