Repository navigation
Conversation
- Run typecheck, lint, test and build on PR and pushes to main/develop - Add lint:ci script without --fix so CI never rewrites sources - Ignore docs directory in ESLint config
- Add Picker class with click and hover detection via Raycaster - Support targets, recursive, filter, layers, near and far options - Coalesce hover raycasts through requestAnimationFrame - Skip raycasting entirely when no listener is registered - Use a click threshold to tell clicks apart from camera drags - Add onClick, onHover, pickFilter and pickRecursive props to Scene - Expose Picker plus PickEvent, PickEventType, PickCallback and PickerOptions from the public entry point - Add unit tests and English and Chinese documentation
- Add LightPillar group with TSL cone, top glow and ground pulse rings - Share one material per layer and drive per-mesh data via attributes - Auto-detect the renderer and pre-correct color on WebGPU - Dispose geometries, materials, the added listener and the rAF loop - Export LightPillar and LightPillarOptions from the public entry point - Add unit tests, dual-renderer demo and bilingual documentation - Drop the unused options argument from the Popup demo - Add a default export condition to package.json for CJS consumers
- Add WGS84/GCJ02/BD09 datum conversion, recentered Web Mercator and local tangent plane projections, and a GeoReference for geographic-to-local mapping - Add Scene origin/crs/datum/axes/geo props, plus object-form gridHelper options - Add GeoObject to anchor objects at geographic coordinates and GeoJsonLayer for GeoJSON geometries - Add TileLayer that streams XYZ raster tiles with quadtree selection, worker image decode and crossfade - Add tests, dual-renderer demos and bilingual documentation COMMIT_EXIT=
- Replace the #1a1a2e scene background with rgb(40, 42, 54) across all demo components, including the equivalent hex literal used by the Bloom demo onCreated handler - Update the matching code samples in the English and Chinese docs - Update the default demo background convention in AGENTS.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify the demo scene background from
#1a1a2etorgb(40, 42, 54)across every demo component and its documentation, and record the convention inAGENTS.mdso future demos do not drift back.What changed
docs/src/components/— the<Scene bgColor="...">value is nowrgb(40, 42, 54); the Bloom demo's equivalent hex literal0x1a1a2ebecamenew THREE.Color('rgb(40, 42, 54)').docs/guide/and 12 Chinese docs indocs/i18n/zh-CN/docusaurus-plugin-content-docs/current/— the matchingtsxsamples were updated so the rendered examples match the live demos.AGENTS.md— the default demo background convention now readsrgb(40, 42, 54).50 files changed, 76 insertions(+), 76 deletions(-). Every changed line is only the background color literal.
Why
The demos and their documentation had drifted onto a mix of the legacy
#1a1a2ehex and the newerrgb(40, 42, 54)value, so pages rendered visibly different backgrounds and copy-pasted samples could pick up the stale color. Pinning a single value — and documenting it inAGENTS.md— keeps every current and future demo consistent.Impact
groundColorfallback in theTileLayerdocs is intentionally left as#1a1a2e, because it documents the library's realDEFAULT_GROUND_COLORdefault rather than a demo background.Validation
#1a1a2eorrgb(40, 42, 54), with zero unrelated lines.eslint .passes (0 errors; one pre-existing warning insrc/components/Scene.tsx).