Skip to content

style(journal): add editor row lines - #8

Merged
casprine merged 17 commits into
mainfrom
codex/strip-non-v1-surfaces
Aug 1, 2026
Merged

casprine merged 17 commits into
mainfrom
codex/strip-non-v1-surfaces

Conversation

@casprine

@casprine casprine commented Aug 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds subtle horizontal row lines behind the journal editor content area.
  • Scopes the ruled-paper styling to JournalEditor so other Lexical editor usages do not inherit it.
  • Reuses the editor line-height as a CSS variable so the row background aligns with paragraph rhythm.

Verification

  • pnpm exec oxfmt --check src/features/journal/components/journal-editor.tsx
  • pnpm run lint exits 0 with existing warnings
  • pnpm run build
  • git diff --check

Summary by CodeRabbit

  • Style
    • Added configurable horizontal ruled lines to the journal editor.
    • Improved journal text spacing and line-height consistency.
    • Refined editor container styling and selected-state presentation.
    • Added separators between timeline entries and removed the vertical connector line.
    • Added a layered paper-inspired journal page background with gradient coloring and subtle grain texture.
    • Added decorative connectors between related journal sections.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f22d5f4-50f0-44b1-957e-7dcc71af6c37

📥 Commits

Reviewing files that changed from the base of the PR and between a90fd17 and 532304b.

📒 Files selected for processing (1)
  • desktop/src/app.css

📝 Walkthrough

Walkthrough

The journal page now uses paper styling with grain texture and layered gradients. Journal editors use configurable boundary and repeating line styles with shared line height. Timeline items now use bottom separators, and indicator connector lines are removed.

Changes

UI visual updates

Layer / File(s) Summary
Journal paper surface
desktop/src/app.css, desktop/src/features/journal/journal.tsx
Adds the journal-paper-page class and applies isolated gradient, grain, child stacking, section positioning, and connector styles.
Shared editor line styling
desktop/src/components/editor/_editor.css
Defines --editor-line-height, adds journal boundary and repeating line styles, adjusts editor-root spacing, removes journal paragraph bottom margins, and uses the shared line-height variable.
Journal editor class wiring
desktop/src/features/journal/components/journal-editor.tsx
Adds the journal-editor-lines class and updates the selected-state .editor-root selector. Import formatting changes use single quotes.
Timeline separator styling
desktop/src/components/shared/timeline.tsx
Adds bottom borders to timeline content except for the final item and removes the indicator connector line.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the journal styling change and the addition of editor row lines.
Description check ✅ Passed The description explains the main changes and lists verification steps, but it omits the template's change type and platform testing sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/strip-non-v1-surfaces

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@desktop/src/components/editor/_editor.css`:
- Around line 41-51: Update the ruled-line background in .journal-editor-lines
.editor-inner and its related declaration to account for the paragraph spacing
of var(--editor-line-height) plus 0.125rem, keeping paragraph starts aligned
with the repeating line grid. Scope the adjustment to the lined editor without
changing other editor styles.

In `@desktop/src/features/journal/components/journal-editor.tsx`:
- Around line 39-40: Update the selected-state class in the journal editor
component to use a Tailwind descendant arbitrary variant targeting .editor-root,
such as [&_.editor-root]:text-green-700!, instead of embedding literal CSS.
Preserve the existing selected background and ring classes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fec7b895-718d-4d59-a879-91a80384d25b

📥 Commits

Reviewing files that changed from the base of the PR and between 40773c4 and 598a248.

📒 Files selected for processing (2)
  • desktop/src/components/editor/_editor.css
  • desktop/src/features/journal/components/journal-editor.tsx

Comment thread desktop/src/components/editor/_editor.css
Comment thread desktop/src/features/journal/components/journal-editor.tsx Outdated
@casprine
casprine merged commit 2189ed6 into main Aug 1, 2026
6 checks passed
@casprine
casprine deleted the codex/strip-non-v1-surfaces branch August 1, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant