Repository navigation
style(journal): add editor row lines - #8
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe journal page now uses paper styling with grain texture and layered gradients. Journal editors use configurable boundary and repeating line styles with shared line height. Timeline items now use bottom separators, and indicator connector lines are removed. ChangesUI visual updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@desktop/src/components/editor/_editor.css`:
- Around line 41-51: Update the ruled-line background in .journal-editor-lines
.editor-inner and its related declaration to account for the paragraph spacing
of var(--editor-line-height) plus 0.125rem, keeping paragraph starts aligned
with the repeating line grid. Scope the adjustment to the lined editor without
changing other editor styles.
In `@desktop/src/features/journal/components/journal-editor.tsx`:
- Around line 39-40: Update the selected-state class in the journal editor
component to use a Tailwind descendant arbitrary variant targeting .editor-root,
such as [&_.editor-root]:text-green-700!, instead of embedding literal CSS.
Preserve the existing selected background and ring classes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: fec7b895-718d-4d59-a879-91a80384d25b
📒 Files selected for processing (2)
desktop/src/components/editor/_editor.cssdesktop/src/features/journal/components/journal-editor.tsx
Summary
JournalEditorso other Lexical editor usages do not inherit it.Verification
pnpm exec oxfmt --check src/features/journal/components/journal-editor.tsxpnpm run lintexits 0 with existing warningspnpm run buildgit diff --checkSummary by CodeRabbit